Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-26561 Fix a bug due to unreleased lock #1938

Merged
merged 3 commits into from
Nov 9, 2021
Merged

MDEV-26561 Fix a bug due to unreleased lock #1938

merged 3 commits into from
Nov 9, 2021

Conversation

ryancaicse
Copy link
Contributor

Fix a bug of unreleased lock ctrl_mutex in the method create_worker_threads

  • The Jira issue number for this PR is: MDEV-18187

Description

TODO: https://jira.mariadb.org/browse/MDEV-26561?filter=-2

Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch
  • This is a bug fix and the PR is based against the earliest branch in which the bug can be reproduced

Backward compatibility

TODO: fill details here, if applicable, or remove the section

ryancaicse and others added 2 commits October 27, 2021 10:10
Fix a bug of unreleased lock ctrl_mutex in the method create_worker_threads
The previous threads locked need to be released too.

This occurs if the initialization of any of the non-first
mutex/conditition variables errors occurs.
@grooverdan grooverdan changed the base branch from 10.7 to 10.2 October 26, 2021 23:17
@grooverdan grooverdan changed the title MDEV-18187 Fix a bug due to unreleased lock MDEV-26561 Fix a bug due to unreleased lock Oct 26, 2021
@grooverdan
Copy link
Member

@ryancaicse , I did a few changed I'd like to you review:

  • I remarked this as MDEV-26561 as its the issue related to the change
  • Moved this back to the earliest 10.2 branch where the bug started.
  • I also added a second commit to release previous mutexes of the other threads. Please make sure it makes sense regardless with jump to err occurs or which iteration of the loop it is.

@grooverdan grooverdan self-assigned this Oct 26, 2021
@MariaDB MariaDB deleted a comment from CLAassistant Oct 26, 2021
@ryancaicse
Copy link
Contributor Author

@grooverdan It looks good. Thanks!

@grooverdan grooverdan merged commit 7c30bc3 into MariaDB:10.2 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants