MDEV-27804 Fails to build - perf schema - thread id of type uintptr_t requires header #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
seems right - https://www.cplusplus.com/reference/cstdint/, need to check if its always included in a C++ context. |
1 task
… requires header While building on GNU/Hurd and kfreebsd. On the C++ standard uintptr_t can be defined in <cstdint> ref: https://www.cplusplus.com/reference/cstdint/ Fixes: 0d44792
grooverdan
changed the title
|
Thanks @sthibaul for the PR. Merged. I'm sorry it just missed the 10.5.15 release and will be in 10.5.16. |
|
This will be used in Debian on mariadb-10.6 1:10.6.7-1: https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/bbec73bad0facc945fa285eb6d68d4eb9d374d05 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses uintptr_t, so needs including cstdint
Description
While building on GNU/Hurd, I got a build error in perfschema, because uintptr_t is used in my_thread.h but cstdint is not included.
How can this PR be tested?
This would need to introduce in the CI a profile that exercices the HAVE_INTEGER_PTHREAD_SELF case.
Basing the PR against the correct MariaDB version