Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-27790: Fix mis-matched braces for compiling on non-Linux targets #2011

Merged
merged 1 commit into from Feb 10, 2022
Merged

MDEV-27790: Fix mis-matched braces for compiling on non-Linux targets #2011

merged 1 commit into from Feb 10, 2022

Conversation

darkain
Copy link
Contributor

@darkain darkain commented Feb 9, 2022

Ran into this while compiling on FreeBSD 13.0-RELEASE

After this one change, it compiles and runs just fine on my FreeBSD Aarch64 server.

Ran into this while compiling on FreeBSD 13.0-RELEASE

After this one change, it compiles and runs just fine on my FreeBSD Aarch64 server.
@grooverdan grooverdan changed the title Fix mis-matched braces for compiling on non-Linux targets MDEV-27790: Fix mis-matched braces for compiling on non-Linux targets Feb 10, 2022
@grooverdan
Copy link
Member

Looks good. Thanks @darkain.

Ok by you @dr-m?

@grooverdan grooverdan self-assigned this Feb 10, 2022
@grooverdan grooverdan requested a review from dr-m February 10, 2022 04:06
@dr-m
Copy link
Contributor

dr-m commented Feb 10, 2022

Thank you for fixing this!

@grooverdan grooverdan merged commit e375f51 into MariaDB:10.8 Feb 10, 2022
Copy link
Contributor

@ericherman ericherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes.
Did buildbot catch this?

@grooverdan
Copy link
Member

grooverdan commented Feb 11, 2022

@ericherman unfortunately not. I'm documenting this and other significant test gaps now.
MDBF-51 for this one.

Other observed gaps as subtasks of MDBF-41 appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants