MDEV-28011 autobake cleanup #2040
Conversation
|
Is Debian 10 distro which is oldest to bes upportes with autobake or Ubuntu 18.04? |
|
Debian 9 + Ubuntu 18.04 |
|
Ok should 10.2 build with Debian 11? |
|
There's a list on https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/constants.py#L21, however I don't quite follow the consistency of minimum/max version for a specific major version. |
| sed 's|-DDEB|-DPLUGIN_TOKUDB=NO -DPLUGIN_MROONGA=NO -DPLUGIN_SPIDER=NO -DPLUGIN_OQGRAPH=NO -DPLUGIN_PERFSCHEMA=NO -WITH_EMBEDDED_SERVER=OFF -DDEB|' -i debian/rules | ||
| fi | ||
|
|
||
| export DEB_BUILD_OPTIONS="nocheck" | ||
|
|
There was a problem hiding this comment.
Is it so that there is no need of running checks when building with autobake-deb.sh`
There was a problem hiding this comment.
Good question, I was just removing the travis condition. It does look like the autobake builders in buildbot do not run tests because of this. I don't know the reasons behind this choice.
| echo $package | cut -d '_' -f 1 | ||
| dpkg-deb -c $package | awk '{print $1 " " $2 " " $6}' | sort -k 3 | ||
| echo "------------------------------------------------" | ||
| done | ||
|
|
There was a problem hiding this comment.
Is this necessary as it seems to be just waste of log space to-do it every time? Should there be something like DEBUG_AUTOBAKE environmental variable to only print when wanted.
There was a problem hiding this comment.
I have doubts people check the contents here too. I was just removing the travis condition.
| echo $package | cut -d '_' -f 1 | ||
| dpkg-deb -c $package | awk '{print $1 " " $2 " " $6}' | sort -k 3 | ||
| echo "------------------------------------------------" | ||
| done | ||
|
|
There was a problem hiding this comment.
Is this necessary as it seems to be just waste of log space to-do it every time? Should there be something like DEBUG_AUTOBAKE environmental variable to only print when wanted.
debian/autobake-deb.sh
Outdated
| # x86 32 bit. | ||
| if [[ $GCCVERSION -lt 40800 ]] || [[ $(arch) =~ i[346]86 ]] | ||
| # Don't build rocksdb package if gcc version is less than 4.8, but everything is, | ||
| # or we are running on x86 32 bit. |
There was a problem hiding this comment.
Comment is not correct anymore as it's not build if we are not on x86 32 bit. There is no check for GCC.
There was a problem hiding this comment.
there's no gcc in distos this old. I thought is was safer to leave as a comment even if not fully accurate.
|
I try to make clean build on Debian 9 VM as there is some problems with Debian control but they should not be related to this but othrwise LGTM. |
Travis is dead to us so we don't need all the conditions around it. Remove depends for no longer supported versions Debian Jessies, and Ubuntu Trusty, Xenial, Wily are all eol as far as we are concerned. The dependancy on an apt cache when running autobake broke the 10.2 aarch64 packages (MDEV-28014). Lets reduce the risk here.
grooverdan
force-pushed
the
bb-10.2-danielblack-autobake-cleanup
branch
from
14fbd6e
to
34fcb7c
Compare
proof of concept test.
The dependency on having a apt-cache present when autobake was run meant removals occurred.
And travis no longer used.