MDEV-28628: Change current Debian package revision scheme #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Debian package revision scheme when using debian/autobake-deb.sh script is: '1:VERSION+maria~LSBNAME' For example if VERSION can be like 10.6.8 and LSBNAME is buster then version and revision is: '1:10.6.8+maria~buster' Which can lead to problem as distro code names can be lexical unordered. For example Debian LSBNAME's can be: Codename Buster is Debian version 10 Codename Bookworm is Debian version 11 This happens because in ASCII table Buster first two digits are 'Bu' and they are in hex 0x42 and 0x75 and Bookworm first digits 'Bo' are they are in hex 0x42 and 0x6F When apt is upgrading it means that: 1:10.6.8+maria~buster is bigger than 1:10.6.8+maria~bookworm and that leads to problems in dist-upgrade process To solve problem revision format is changed to: '1:VERSION+maria~(deb|ubu)LSBVERSION' Example for Debian 11 is now: 1:10.6.8+maria~deb11 and for Ubuntu 22.04 is now: 1:10.6.8+maria~ubu2204 There are new Variables * VERSION which contains whole version string * LSBVERSION which contains LSB version of distro * LSBID which contains LSB ID (Debian or Ubuntu) added to debian/autobake-deb.sh. Also CODENAME is change to LSBNAME as it's more declaritive
|
@ottok this follows your guidance in the MDEV. Any objections? |
ottok
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
LGTM
For reference, MariaDB versions that are specific for Ubuntu use versions like https://launchpad.net/ubuntu/+source/mariadb-10.5/1:10.5.15-0ubuntu0.21.10.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Debian package revision scheme when using debian/autobake-deb.sh script is:
1:VERSION+maria~LSBNAMEFor example if VERSION can be like 10.6.8 and LSBNAME is buster then version and revision is:
1:10.6.8+maria~busterWhich can lead to problem as distro code names can be lexical unordered.
For example Debian LSBNAME's can be:
Codename Buster is Debian version 10
Codename Bookworm is Debian version 11
This happens because in ASCII table Buster first two digits are 'Bu' and they are in hex 0x42 and 0x75 and Bookworm first digits 'Bo' are they are in hex 0x42 and 0x6F. When apt is upgrading it means that:
1:10.6.8+maria~busteris bigger than1:10.6.8+maria~bookwormand that leads to problems in dist-upgrade process
To solve problem revision format is changed to:
1:VERSION+maria~(deb|ubu)LSBVERSIONExample for Debian 11 is now:
1:10.6.8+maria~deb11and for Ubuntu 22.04 is now:
1:10.6.8+maria~ubu2204There are new Variables
added to
debian/autobake-deb.sh.Also CODENAME is change to LSBNAME as it's more declaritive
How can this PR be tested?
This can be tested manually in Ubuntu or Debian
If compiling on Debian 11 after that there should be deb packages named: mariadb-*+maria~deb11.deb
This is also testes on 10.9 branch on Salsa-CI:
https://salsa.debian.org/illuusio/mariadb-server/-/pipelines/384410
Basing the PR against the correct MariaDB version
Backward compatibility
Makes sure that user can upgrade from Buster to Bookworm