Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
MDEV-11064 - Restrict the speed of reading binlog from Master #246
In some case, the speed of reading binlog from master is high, especially when doing a new replica.
It can work when slave_compressed_protocol is on.
Thanks for your contribution. JIRA task has been created to track this pull request: https://jira.mariadb.org/browse/MDEV-11064
This task was added to 10.2.4 backlog, which is planned to be handled between 2016-11-10 and 2016-11-17.
Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license.
The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/
Please indicate in a comment below that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.
Sergey Vojtovich email@example.com writes:
This is a deliberate lie. There is no such requirement. In fact, most of the
You already indicated that your code is contributed under the GPLv2 by
Please consider keeping your contribution under the GPLv2. Like other open
You are of course free to use whatever license you choose for your own
Otherwise, I will be happy to look into it, probably sometimes during the
GCSAdmin firstname.lastname@example.org writes:
Overall this looks clean and simple.
There is one problem. The patch adds a field real_network_read_len to the
One option might be to introduce new functions like cli_safe_read_reallen()
A smaller issue is that in case of a large packet, a large my_sleep() may be
Detailed comments on the patch below. I rebased the series against latest
As explained above, I believe this would break the ABI (that's the purpose
Generally, lines longer than 80 characters should be avoided (coding style).
As explained above, probably better to use slave_sleep() here to allow STOP
Would it make sense to do this wait after calling queue_event()? This way
What do you think?
Thanks for you suggestions for this patch.
cli_safe_read_reallen() and and my_net_read_packet_reallen() is a good way to fix the ABI problem. I will fix it like this.
And the minimum precision is second in slave_sleep(), and it also a the mutex. I think it is too heavy in most case. (It will wait millisecond seconds usually)
Is it ok?
vinchen email@example.com writes:
Yes, it looks fine thanks!
And thanks for the explanation, yes now I see that usually the sleep will be
I'll merge it like this after checking that everything compiles and tests