Skip to content

Conversation

@andremralves
Copy link
Contributor

@andremralves andremralves commented Mar 16, 2024

  • The Jira issue number for this PR is: MDEV-33618

Description

  • Add mariadbd_safe to be used as an option group in my.cnf
  • Update man page.

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2024

CLA assistant check
All committers have signed the CLA.

@tonychen2001
Copy link
Contributor

Also need to change references of mariadb_safe to mariadbd-safe in man/mysqld_safe.1

@andremralves
Copy link
Contributor Author

Also need to change references of mariadb_safe to mariadbd-safe in man/mysqld_safe.1

I wasn't sure if I should change the man pages because mariadb_safe still works, but I think it's better. Thanks.

@LinuxJedi
Copy link
Contributor

Also need to change references of mariadb_safe to mariadbd-safe in man/mysqld_safe.1

I wasn't sure if I should change the man pages because mariadb_safe still works, but I think it's better. Thanks.

Yes mariadb_safe works, but it is deprecated, so I think removing it from the man is safe. If you could add mariadbd-safe as well to what you have done, I think this is in a good place.

@grooverdan grooverdan added the need feedback Can the contributor please address the questions asked. label Apr 30, 2024
@andremralves
Copy link
Contributor Author

Yes mariadb_safe works, but it is deprecated, so I think removing it from the man is safe. If you could add mariadbd-safe as well to what you have done, I think this is in a good place.

Hi @LinuxJedi, thanks for the clarifications. I also added mariadbd-safe to the man page.

@andremralves andremralves requested a review from grooverdan April 30, 2024 07:20
Copy link
Contributor

@LinuxJedi LinuxJedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for fixing that.

@LinuxJedi LinuxJedi removed the need feedback Can the contributor please address the questions asked. label Jun 4, 2024
@LinuxJedi LinuxJedi enabled auto-merge (rebase) June 18, 2024 05:59
@LinuxJedi LinuxJedi merged commit 0dfc9ec into MariaDB:11.5 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants