Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNU/Hurd cmake configuration #918

Merged
merged 1 commit into from May 21, 2019
Merged

Add GNU/Hurd cmake configuration #918

merged 1 commit into from May 21, 2019

Conversation

sthibaul
Copy link
Contributor

@sthibaul sthibaul commented Nov 6, 2018

No description provided.

@an3l
Copy link
Contributor

an3l commented Nov 7, 2018

Hi @sthibaul ,

Thanks for your contribution.
Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license.
The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/
Please indicate in a comment below, or update your PR comment that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
Anel


# This file includes GNU/Hurd specific options and quirks, related to system checks

INCLUDE(CheckSymbolExists)
Copy link
Member

@vaintroub vaintroub Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you do not really need that line.

@sthibaul
Copy link
Contributor Author

sthibaul commented Nov 8, 2018

Yes, I'm contributing this contribution under BSD-new.
I have only put the GPL header because I mostly copied this from Linux.cmake.

@an3l an3l added this to the 10.4 milestone Nov 13, 2018
@jonoxer jonoxer added the license-bsd-new Contributed under BSD-new license label Nov 14, 2018
@sthibaul
Copy link
Contributor Author

sthibaul commented Jan 4, 2019

Any news on this? At some point my patch will become outdated, and I'll have to rework it completely...

@an3l an3l requested a review from vaintroub Mar 11, 2019
@svoj svoj merged commit fceffcd into MariaDB:10.4 May 21, 2019
1 check failed
@svoj
Copy link

svoj commented May 21, 2019

Thanks and sorry that it took so long. File got somewhat out of date indeed. Though nothing serious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
license-bsd-new Contributed under BSD-new license
5 participants