Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BusinessBase Exposes a Save Method in .NET Core Projects #710
Updated by @rockfordlhotka
As noted later in this thread, the issue is that BusinessBase exposes a sync
Original text from @rabidkitten:
Using CSLA-Core 4.6.500 (the latest at the time of this writing).
Classes that inherit BusinessListBase do not expose a .Save method when used in a .NET Core assembly. I am getting around this by using .SaveAsync(). Objects that implement BusinessBase have the Save method. In a non-.NET Core assembly, the Save method is visible.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
The BusinessListBase.Save method has this conditional compilation: #if !(ANDROID || IOS) && !NETFX_CORE I assume it can be removed to support Save for .NET Core projects.
I didn't finish my test, because I assume to load/reference CSLA for .NET Core projects I need VS 2017.
This is a bug - the history is that UWP doesn't support synchronous IO operations, and it was the first ".NET Core" platform - so when I added support for UWP I had to remove the sync
I actually think the bug here is that I didn't block out the sync method on
It remains to be seen whether I'll choose to support any sync data portal behaviors in .NET Core, given that the world is clearly moving to async overall.
To your VS2017 question @rob-v - the current master branch has been updated to 2017. But I am told that you can work with .NET Core projects using vscode as well, so 2017 probably isn't a strict requirement.