Patch site navigation rendering of dropdown menus #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamgent
reviewed
Jul 2, 2018
| const nestedList = $(this).children().first(); | ||
| const dropdownTitle = $(this).contents().first().text(); | ||
| // Do not render dropdown menu for list items with <a> tag | ||
| if ($(this).children('a').length) { |
There was a problem hiding this comment.
Would be better if this was more explicit:
if ($(this).children('a').length > 0) {There was a problem hiding this comment.
It follows Javascript style where we use the truthy values from an integer directly without doing an explicit comparison since it is guaranteed that the value is an integer >= 0.
| nestedList.parent().replaceWith(formatSiteNav(nestedList.parent().html())); | ||
| } | ||
| // Found nested list, render dropdown menu | ||
| } else if ($(this).children('ul').length) { |
There was a problem hiding this comment.
Same here:
} else if ($(this).children('ul').length > 0) {There was a problem hiding this comment.
Comment above.
lib/Page.js
Outdated
| @@ -131,14 +140,6 @@ function formatSiteNav(renderedSiteNav) { | |||
| // Recursively format nested lists | |||
| nestedList.replaceWith(formatSiteNav(nestedList.parent().html())); | |||
| // Found element that is not a list, with nested items | |||
There was a problem hiding this comment.
This comment should be deleted now.
yamgent
reviewed
Jul 2, 2018
Chng-Zhi-Xuan
force-pushed
the
272-patch-site-nav
branch
from
8d91288
to
b3b1a33
Compare
|
Update
|
yamgent
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Fixes #272
What is the rationale for this request?
What changes did you make? (Give an overview)
formatSiteNavto account for styling tags in dropdown menu titlesdropdown-btnCSS to align text to the left.Is there anything you'd like reviewers to focus on?
formatSiteNavTesting instructions:
markbind serveon thetest_sitefolder.