From 92e1dbc8886baab0b867152c7a9465a74e54005b Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Thu, 23 Nov 2023 08:52:52 -0700 Subject: [PATCH] Avoid data-tables, echarts, and prism upper bounds error (#2682) --- pct.sh | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/pct.sh b/pct.sh index 83b6f1f35..422d49e7c 100755 --- a/pct.sh +++ b/pct.sh @@ -19,6 +19,28 @@ if ! [[ $PLUGINS =~ blueocean || $PLUGINS =~ pipeline-maven ]]; then # PCT_D_ARGS+='-DforkCount=.75C ' fi +if [[ $PLUGINS =~ data-tables-api || $PLUGINS =~ echarts-api || $PLUGINS =~ prism-api ]]; then + # + # These plugins use a version of ArchUnit which triggers a + # requireUpperBoundDeps error with JUnit 5: + # + # +-io.jenkins.plugins:data-tables-api:1.13.8-1 + # +-com.tngtech.archunit:archunit-junit5:1.2.0 [test] + # +-com.tngtech.archunit:archunit-junit5-engine:1.2.0 [test] + # +-com.tngtech.archunit:archunit-junit5-engine-api:1.2.0 [test] + # +-org.junit.platform:junit-platform-engine:1.10.0 [test] (managed) + # <-- org.junit.platform:junit-platform-engine:1.10.1 [test] + # + # Since PCT will automatically resolve requireUpperBoundDeps errors by + # choosing the newer version, and since the newer version is not + # ABI-compatible with the older version, exclude this package from PCT's + # requireUpperBoundDeps resolution. + # + # TODO: When these plugins are fixed to not trigger a requireUpperBoundDeps + # error, this code should be removed. + # + PCT_D_ARGS+='-DupperBoundsExcludes=org.junit.platform:junit-platform-commons ' +fi exec java \ -jar target/pct.jar \