Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spacer Staff Type #64

Merged
merged 7 commits into from Aug 5, 2017

Conversation

Projects
None yet
1 participant
@MarkOates
Copy link
Owner

commented Aug 5, 2017

Problem

Would be nice to have some dividers between the different instrument groups in the score.

Solution

Now that staff types are in place, we can add new staff types. Add Staff::Spacer type.

This required a lot of refactoring in the MeasureGrid which assumes that inserting (or appending) any staff will always be a Staff::Instrument type. Now, the staff needs to be created externally via new and passed as an argument. This caused a few cracks in the code. These adjustments are included in this PR.

fullscore 2017-08-05 00-02-36

Future adjustments might include having a staff report its height, and rendering bar lines within staves instead of across all staves.

@MarkOates MarkOates merged commit 452959f into master Aug 5, 2017

@MarkOates MarkOates deleted the add-spacer-staff-type branch Aug 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.