Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tempo Staff Type #82

Merged
merged 15 commits into from Aug 27, 2017

Conversation

Projects
None yet
1 participant
@MarkOates
Copy link
Owner

commented Aug 27, 2017

Problem

We don't have any tempo data in our music.

Solution

Add a Tempo staff type, where tempo markings can be placed. Also added is a TempoMarking model, that contains a duration and BPM. The Tempo staff contains multiple TempoMarkings and their coordinates in the staff.

fullscore 2017-08-27 19-32-52

Future

  • Improve the rendering of the marking, which is simply a text string right now
  • Add support for different tempo marking types (accel, "Presto", etc). Right now it's just a fixed "♩= 120" type.

@MarkOates MarkOates force-pushed the add-tempo-staff branch from 6d2f3b6 to f2918da Aug 27, 2017

@MarkOates MarkOates merged commit 28f610c into master Aug 27, 2017

@MarkOates MarkOates deleted the add-tempo-staff branch Aug 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.