From 56d3c6032d76514d6317486d90aeb17e3b762094 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Luthi?= Date: Fri, 21 Oct 2022 21:37:32 +0200 Subject: [PATCH] Pass the cancellationToken to InitializeAsync And increase CA2016 severity to warning in order to catch these issues --- .editorconfig | 2 ++ source/Sylvan.Data.Csv/CsvDataReader+Async.cs | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.editorconfig b/.editorconfig index b2a6ae38..c412c657 100644 --- a/.editorconfig +++ b/.editorconfig @@ -13,6 +13,8 @@ dotnet_style_require_accessibility_modifiers = never # CA1028: If possible, make the underlying type of PrimitiveType System.Int32 instead of byte. dotnet_diagnostic.CA1028.severity = none +# CA2016: Forward the CancellationToken parameter to methods that take one +dotnet_diagnostic.CA2016.severity = warning # xUnit2013: Do not use equality check to check for collection size. dotnet_diagnostic.xUnit2013.severity = suggestion diff --git a/source/Sylvan.Data.Csv/CsvDataReader+Async.cs b/source/Sylvan.Data.Csv/CsvDataReader+Async.cs index 7abe3d05..c5ac1943 100644 --- a/source/Sylvan.Data.Csv/CsvDataReader+Async.cs +++ b/source/Sylvan.Data.Csv/CsvDataReader+Async.cs @@ -289,7 +289,7 @@ public override async Task ReadAsync(CancellationToken cancellationToken) public override async Task NextResultAsync(CancellationToken cancellationToken) { while (await ReadAsync(cancellationToken)) ; - return await InitializeAsync(); + return await InitializeAsync(cancellationToken); } #if NETSTANDARD2_1