New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-framework: Test Script and Test Support Files should not be able to have same name. #1022

Closed
yc2lee opened this Issue Mar 2, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@yc2lee
Contributor

yc2lee commented Mar 2, 2013

Currently, if you upload a Test Script File called S and then upload a Test Support File with the same name S, then the Test Support File upload will overwrite the Test Script File. So in the end, there will just be one file in the data folder.

@umsmit32

This comment has been minimized.

Show comment
Hide comment
@umsmit32

umsmit32 Mar 9, 2013

Contributor

I'll take a look at this.

Contributor

umsmit32 commented Mar 9, 2013

I'll take a look at this.

benjaminvialle added a commit that referenced this issue Mar 11, 2013

Merge pull request #1045 from umsmit32/issue-1022
When a test script and support file gets uploaded the first time it is passed differently in the params hash than when it's created and updated. This caused the check for repeat filenames to not work properly when a a file being created is the same as an existing file. Added a line to add files being updated.
Closes #1022
@danielstjules

This comment has been minimized.

Show comment
Hide comment
@danielstjules

danielstjules Sep 7, 2013

Member

Fixed via #1045

Member

danielstjules commented Sep 7, 2013

Fixed via #1045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment