Update areas of code base to correctly use appropriate submission result (original vs remark result) #1027

Closed
akwok18 opened this Issue Mar 4, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@akwok18
Contributor

akwok18 commented Mar 4, 2013

As a result of PR #1026 for issue #941, it was realized that the majority of the code base always uses the original result, regardless if it would be more appropriate to be using the remark result, it it exists.

Suggested fix:
Implement another helper method get_latest_result that would utilize the current helper methods get_original_result, get_remark_result, has_remark?, and remark_submitted? to return the latest completed result. Determine areas where this method would be appropriate to use instead of always using the original result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment