New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-populate the rubric with the original result at the start of remarking #1028

Closed
m-wu opened this Issue Mar 4, 2013 · 13 comments

Comments

Projects
None yet
3 participants
@m-wu
Contributor

m-wu commented Mar 4, 2013

As an instructor begins remarking, pre-populate the rubric with the original marks, while keeping all sections expended, so that the process can be speeded up as usually only a few criteria need to be remarked.

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Mar 5, 2013

Contributor

The idea of this is good but I don't think it is a good thing to implement. My main concern is how will an instructor know which criteria they have re-marked and which one they haven't. Just having all section expanded is not enough to distinguish the difference. If the session ever times out or the instructor browse away from the marking page, when they return all the sections will be expanded again and there is no way of knowing which was marked and which was not.

Contributor

mikeing2001 commented Mar 5, 2013

The idea of this is good but I don't think it is a good thing to implement. My main concern is how will an instructor know which criteria they have re-marked and which one they haven't. Just having all section expanded is not enough to distinguish the difference. If the session ever times out or the instructor browse away from the marking page, when they return all the sections will be expanded again and there is no way of knowing which was marked and which was not.

@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Mar 5, 2013

Contributor

Okay, I see your concern here. Now I'm wondering if it really makes sense to expand all sections at the beginning of remarking? Maybe letting users expand individual sections as needed is a more straightforward user experience? The sections for which the user does not expand to change the mark will be set to the same old marks on save.

Of course my assumption here is that often only a few criteria are needed to be changed. It's possible that this is not the case if instructors would like to always re-grade the entire assignment, even when the given remark request is rather specific. @reidka : could you provide some user input as an instructor? Thank you!

Contributor

m-wu commented Mar 5, 2013

Okay, I see your concern here. Now I'm wondering if it really makes sense to expand all sections at the beginning of remarking? Maybe letting users expand individual sections as needed is a more straightforward user experience? The sections for which the user does not expand to change the mark will be set to the same old marks on save.

Of course my assumption here is that often only a few criteria are needed to be changed. It's possible that this is not the case if instructors would like to always re-grade the entire assignment, even when the given remark request is rather specific. @reidka : could you provide some user input as an instructor? Thank you!

@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Mar 6, 2013

Member

Your assumption that only a few criteria will be changed in a remark request is true, so I like the idea that the marks in the remark result are populated with the original. I would still like to see the criteria list expanded. I tend to mark with the list expanded so it would be extra clicks to open each one up separately.

Member

reidka commented Mar 6, 2013

Your assumption that only a few criteria will be changed in a remark request is true, so I like the idea that the marks in the remark result are populated with the original. I would still like to see the criteria list expanded. I tend to mark with the list expanded so it would be extra clicks to open each one up separately.

@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Mar 6, 2013

Contributor

Okay, I see. Thanks for the input! I'll take into account the concern and these requirements as I explore the implementations.

Contributor

m-wu commented Mar 6, 2013

Okay, I see. Thanks for the input! I'll take into account the concern and these requirements as I explore the implementations.

@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Mar 13, 2013

Contributor

Here is a proposed implementation:

For a fresh remark request, old marks are highlighted in the rubric, but not actually set as the remark result in the database. This would give user the impression that these marks would stay the same if they are not changed. And they are not required to click on old marks, so once the instructor finishes remarking, any criteria without a new mark will be given the old mark in the remark result.

I think this avoids the implementation concern and achieves the pre-populating effect.

At the beginning of remarking:
Screenshot from 2013-03-12 14:44:35

A remarked is entered and rubric is once again expanded:
Screenshot from 2013-03-12 14:48:05

Contributor

m-wu commented Mar 13, 2013

Here is a proposed implementation:

For a fresh remark request, old marks are highlighted in the rubric, but not actually set as the remark result in the database. This would give user the impression that these marks would stay the same if they are not changed. And they are not required to click on old marks, so once the instructor finishes remarking, any criteria without a new mark will be given the old mark in the remark result.

I think this avoids the implementation concern and achieves the pre-populating effect.

At the beginning of remarking:
Screenshot from 2013-03-12 14:44:35

A remarked is entered and rubric is once again expanded:
Screenshot from 2013-03-12 14:48:05

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Mar 13, 2013

Contributor

This sound like a great way to implement it. Just one comment. Once a mark has been giving for a certain criteria, you minimize it. There is no need to keep it expanded.

Contributor

mikeing2001 commented Mar 13, 2013

This sound like a great way to implement it. Just one comment. Once a mark has been giving for a certain criteria, you minimize it. There is no need to keep it expanded.

@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Mar 13, 2013

Contributor

@mikeing2001 Okay! Yes, the second screenshot was to show what would happen if you manually expand the criterion again; I won't change the auto-collapsing behaviour. :)

Contributor

m-wu commented Mar 13, 2013

@mikeing2001 Okay! Yes, the second screenshot was to show what would happen if you manually expand the criterion again; I won't change the auto-collapsing behaviour. :)

@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Mar 13, 2013

Member

I like it. The only change I would like to request is to make the new mark green instead of red. Red has a negative connotation.

Member

reidka commented Mar 13, 2013

I like it. The only change I would like to request is to make the new mark green instead of red. Red has a negative connotation.

@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Mar 20, 2013

Member

I like the idea of highlighting the changed marks but pre-populating the remark result. That way I can tell if I've changed a rubric elemetn.

Member

reidka commented Mar 20, 2013

I like the idea of highlighting the changed marks but pre-populating the remark result. That way I can tell if I've changed a rubric elemetn.

@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Mar 20, 2013

Contributor

Sorry @reidka, did you mean the remark result should or shouldn't be pre-populated in the database with the original result? I think the problem with pre-populating, as raised by @mikeing2001, is that a partial remark would just look like a completed remark, but I'm not sure how significant the problem is in reality.

On the other hand, not doing the pre-populating in the database would cause the inconsistency of having both a projected remark result and the actual (partial) remark result, and a various of UI element would need to decide which one to use.

I think if remarking is often done in one session, the problem raised by @mikeing2001 is not too much of a concern, and we can keep things consistent and simple.

Contributor

m-wu commented Mar 20, 2013

Sorry @reidka, did you mean the remark result should or shouldn't be pre-populated in the database with the original result? I think the problem with pre-populating, as raised by @mikeing2001, is that a partial remark would just look like a completed remark, but I'm not sure how significant the problem is in reality.

On the other hand, not doing the pre-populating in the database would cause the inconsistency of having both a projected remark result and the actual (partial) remark result, and a various of UI element would need to decide which one to use.

I think if remarking is often done in one session, the problem raised by @mikeing2001 is not too much of a concern, and we can keep things consistent and simple.

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Mar 20, 2013

Contributor

This is what I think Karen is talking about which is an easier implementation. Pre-populate the database with the old marks. But in the rubric have a colour scheme to indicate what is the original old mark and what is the new remarked mark.

Contributor

mikeing2001 commented Mar 20, 2013

This is what I think Karen is talking about which is an easier implementation. Pre-populate the database with the old marks. But in the rubric have a colour scheme to indicate what is the original old mark and what is the new remarked mark.

@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Mar 20, 2013

Contributor

Okay great! Thanks for your help! :)

Contributor

m-wu commented Mar 20, 2013

Okay great! Thanks for your help! :)

@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Mar 21, 2013

Member

+1
I like pre-populating the remark result. The colour coding will help, and a remarker will have to make a decision when to release the mark to indicate that he or she is finished remarking.

Member

reidka commented Mar 21, 2013

+1
I like pre-populating the remark result. The colour coding will help, and a remarker will have to make a decision when to release the mark to indicate that he or she is finished remarking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment