New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to release a partial submission with a remark will display notification that update was successful even though it wasn't. #1031

Closed
akwok18 opened this Issue Mar 5, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@akwok18
Contributor

akwok18 commented Mar 5, 2013

Steps to reproduce:

  1. (from student) request a remark
  2. (from teacher) navigate to grades table
  3. select group that has a remark request
  4. click "Release Marks" button

Expected:

  • display a notification that there is an error because marking state is not complete
    Actual:
  • displays successfully updated (even though it is not actually released, and marking state remains as partial)
@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Mar 6, 2013

Contributor

Related to #1018, i.e. the buttons try to release the original result. But the notification after trying to release an already released result should be changed from "Successfully updated 1 results" (since nothing was actually updated for this result).

Contributor

m-wu commented Mar 6, 2013

Related to #1018, i.e. the buttons try to release the original result. But the notification after trying to release an already released result should be changed from "Successfully updated 1 results" (since nothing was actually updated for this result).

@akwok18

This comment has been minimized.

Show comment
Hide comment
@akwok18

akwok18 Mar 6, 2013

Contributor

Using original result instead of remark if exists is related to issue #1027

Contributor

akwok18 commented Mar 6, 2013

Using original result instead of remark if exists is related to issue #1027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment