New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no search functionality on the User tab. #1358

Closed
kitiya opened this Issue Feb 9, 2014 · 11 comments

Comments

Projects
None yet
6 participants
@kitiya

kitiya commented Feb 9, 2014

We should be able to search for students, grader and admin.

@kitiya

This comment has been minimized.

Show comment
Hide comment
@kitiya

kitiya Feb 9, 2014

I would like to work on this issue.

kitiya commented Feb 9, 2014

I would like to work on this issue.

@munrocape

This comment has been minimized.

Show comment
Hide comment
@munrocape

munrocape Feb 9, 2014

Contributor

@kitiya I'll help with the implementation of the UI/CSS. The associated file is the students view. From the website, the Users/Students tab for an admin.

Contributor

munrocape commented Feb 9, 2014

@kitiya I'll help with the implementation of the UI/CSS. The associated file is the students view. From the website, the Users/Students tab for an admin.

@munrocape

This comment has been minimized.

Show comment
Hide comment
@munrocape

munrocape Feb 9, 2014

Contributor

@kitiya Turns out was rather easy - a search box / functionality exists in the groups view. The related branch is here: https://github.com/munrocape/Markus/tree/student-search-button 🔎

Contributor

munrocape commented Feb 9, 2014

@kitiya Turns out was rather easy - a search box / functionality exists in the groups view. The related branch is here: https://github.com/munrocape/Markus/tree/student-search-button 🔎

@kitiya

This comment has been minimized.

Show comment
Hide comment
@kitiya

kitiya Feb 13, 2014

@munrocape This is good news for me. It would be a good start for me to get to know the application by working on this issue.

kitiya commented Feb 13, 2014

@munrocape This is good news for me. It would be a good start for me to get to know the application by working on this issue.

@munrocape

This comment has been minimized.

Show comment
Hide comment
@munrocape

munrocape Feb 13, 2014

Contributor

@kitiya We now have a design decision that perhaps @reidka could weigh in on. We could add filter/search to the "Bulk Actions" drop down menu that when selected would add a search bar, or, we could have it permanently to the right of the "Bulk Actions" form.

Personally, I think it should be separate. I imagine a typical use would be filter for student(s) + bulk action on them. Less clicks in the drop down this way, and it is easier to modify the search field if you want to perform action x on numerous different searches.

Contributor

munrocape commented Feb 13, 2014

@kitiya We now have a design decision that perhaps @reidka could weigh in on. We could add filter/search to the "Bulk Actions" drop down menu that when selected would add a search bar, or, we could have it permanently to the right of the "Bulk Actions" form.

Personally, I think it should be separate. I imagine a typical use would be filter for student(s) + bulk action on them. Less clicks in the drop down this way, and it is easier to modify the search field if you want to perform action x on numerous different searches.

@munrocape

This comment has been minimized.

Show comment
Hide comment
@munrocape

munrocape Feb 25, 2014

Contributor

@kitiya It looks like this is already implemented yet something may be broken (somewhere). In the associated _boot.js file the FilterTable class is implemented yet there is no associated search bar.

A pure-jQuery solution is not feasible as the table cannot be searched through typical DOM manipulations.

Related wiki: https://github.com/MarkUsProject/Markus/wiki/FilterTable

Contributor

munrocape commented Feb 25, 2014

@kitiya It looks like this is already implemented yet something may be broken (somewhere). In the associated _boot.js file the FilterTable class is implemented yet there is no associated search bar.

A pure-jQuery solution is not feasible as the table cannot be searched through typical DOM manipulations.

Related wiki: https://github.com/MarkUsProject/Markus/wiki/FilterTable

@kitiya

This comment has been minimized.

Show comment
Hide comment
@kitiya

kitiya Feb 26, 2014

@munrocape This seems to be more complicated than what I had expected. I am not sure about the solution yet.

kitiya commented Feb 26, 2014

@munrocape This seems to be more complicated than what I had expected. I am not sure about the solution yet.

@david-yz-liu

This comment has been minimized.

Show comment
Hide comment
@david-yz-liu

david-yz-liu Jun 16, 2014

Contributor

We can filter by name and username, which is good enough for me right now.

Contributor

david-yz-liu commented Jun 16, 2014

We can filter by name and username, which is good enough for me right now.

@munrocape

This comment has been minimized.

Show comment
Hide comment
@munrocape

munrocape Jul 15, 2014

Contributor

@david-yz-liu What other functionality would be beneficial?

Playing around on the demo, I think that this could be expanded across to section as well as number of grace credits left.

Contributor

munrocape commented Jul 15, 2014

@david-yz-liu What other functionality would be beneficial?

Playing around on the demo, I think that this could be expanded across to section as well as number of grace credits left.

@arkon

This comment has been minimized.

Show comment
Hide comment
@arkon

arkon Jul 15, 2014

Member

@munrocape @oneohtrix is working on replacing the tables, so he might be able to add those.

Member

arkon commented Jul 15, 2014

@munrocape @oneohtrix is working on replacing the tables, so he might be able to add those.

@lvwrence

This comment has been minimized.

Show comment
Hide comment
@lvwrence

lvwrence Jul 15, 2014

Contributor

Yeah the new tables support sorting and searching on any column.

Contributor

lvwrence commented Jul 15, 2014

Yeah the new tables support sorting and searching on any column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment