Section Due Dates don't work #1676

Closed
david-yz-liu opened this Issue Aug 15, 2014 · 16 comments

Projects

None yet

3 participants

@david-yz-liu
Contributor

There seem to be numerous problems with these. I did some testing a few days ago and I don't think they always take effect (perhaps when they're before the global due date).

Also, I think in some places for the students, the global due date is shown/used instead of the section due date.

Just logging this issue for someone to look at more carefully later.

@david-yz-liu
Contributor

From #1702:

If the timezone is changed from the default, two functional tests related to section due dates fail.

See #211 for more information.

@reidka reidka referenced this issue Jan 25, 2016
Closed

Sections #2446

@alexinman
Contributor

@david-yz-liu I'm just looking into this one now and have a couple questions.

  1. How do I change the timezone?

  2. Should the due dates be for the server time or for the users time? (At 3:00pm, I set a due date to be 2:50pm, and there was a pop up saying I was setting it in the past, which makes sense. But then afterwards it seems to be using a server time, which is an hour earlier, so the 2:50pm due date is actually being used as a 3:50pm due date.)

  3. Where are all the different locations that a student can see the due date for an assignment? I've found the following locations:

  • Home page, in the Assignments Table, Due Date column
  • Assignment - Student Interface, under Assignment Rules
  • Although it doesn't actually say the due date, the submission page will say when its past the due date
@alexinman
Contributor

One problem, I've found so far with Section Due Dates:
screen shot 2016-01-30 at 4 34 33 pm 2
The time left part of that table cell seems to be calculated from the global due date, even though there is a section due date set.

@alexinman
Contributor

Another problem:
screen shot 2016-01-30 at 4 38 36 pm
This seems to only be an issue when section due dates are being used for the assignment even if the student isn't in a section with a specified due date, if the global due date has passed, no due date shows up. If the student is in a section with a specified due date, then if their section due date has passed, no due date shows up.

@alexinman
Contributor

Another problem:
When you submit a file after the due date the student normally gets these messages:
screen shot 2016-01-30 at 5 01 40 pm
But if the section due date has passed, but the global due date has not, they only get these messages:
screen shot 2016-01-30 at 5 02 19 pm

@david-yz-liu
Contributor

@alexinman Thanks for the screenshots. Supremely helpful.

  1. On Rails, try changing the time zone with http://stackoverflow.com/questions/6118779/how-to-change-default-timezone-for-active-record-in-rails
  2. I don't think MarkUs does anything sophisticated with timezones - all the dates should be shown in the browser assuming the server's time zone. I thought that was what happened now, but I guess I could be wrong. The datetime picker might be doing something different, now that I think about it.
  3. That's all of them, I think. Students don't have a lot of views.
@alexinman
Contributor

Just did some testing with submitting assignments before/after global/section due dates, and it seems the messages issue I was seeing above is a part of a larger issue of when students submit assignments after the section due date, but before the global due date. The files still get accepted and are able to be graded by the instructor/TA.

@alexinman alexinman added a commit to alexinman/Markus that referenced this issue Feb 4, 2016
@alexinman alexinman Fix for section due date not showing up in student assignments view. …
…Fix for time left incorrect for section due dates. (#1676)
a5e9828
@alexinman alexinman added a commit to alexinman/Markus that referenced this issue Feb 11, 2016
@alexinman alexinman Work on fixing section due dates. Changed messages about collection t…
…imes for sections. Changed submission rules to include sections when calculating collection time. (#1676)
32ddae3
@alexinman
Contributor

@david-yz-liu: Currently the submissions/browse page looks like this:
screen shot 2016-02-12 at 9 46 52 am
with the 'Collect All Submissions' link at the top. Is it alright if I move it down to beside the Release/Unrelease marks? It would look something like this:
screen shot 2016-02-12 at 9 43 16 am
Doing this makes it more consistent/easier for when I add a drop down when there are separate section due dates, which would look sort of like this:
screen shot 2016-02-12 at 9 52 47 am

@david-yz-liu
Contributor

That's fine, but please insert a divider between that button and the Release/Unrelease buttons.

@reidka
Member
reidka commented Feb 12, 2016

I like having Collect submissions as a button, but agree with @david-yz-liu that it isn't clear that the dropdown goes with the Collection button.

@alexinman alexinman added a commit to alexinman/Markus that referenced this issue Feb 12, 2016
@alexinman alexinman Changed 'Collect All Submissions' link to a button, in preparation fo…
…r collecting section submissions. Fixed bug in submission_rule that I didn't notice in my last commit. (#1676)
4e9a474
@alexinman alexinman added a commit to alexinman/Markus that referenced this issue Feb 19, 2016
@alexinman alexinman Added in the ability to collect a single sections submissions or coll…
…ect all the sections that have had their due date pass (#1676)
56206cf
@alexinman alexinman added a commit to alexinman/Markus that referenced this issue Feb 19, 2016
@alexinman alexinman Fixed bug where if section was nil in submission_rule#get_collection_…
…time a NoMethodError was thrown. (#1676)
7298fee
@david-yz-liu
Contributor

@alexinman you've made great progress, thanks a lot.

One outstanding issue I noticed: MarkUs allows some students to be assigned a section, and others not to be. This is not taken into account when doing collection. When you have time, please add an "unassigned" option to the section dropdown, which causes the submissions of the students who aren't in a section to be collected.

@alexinman
Contributor

Yes sure thing. Do you want that before or after I write the tests for section due dates?

@david-yz-liu
Contributor

After, please.

@alexinman
Contributor

This can be closed now, right?

@david-yz-liu
Contributor

@alexinman Somehow I missed this - thanks again for all your hard work last term!

@alexinman
Contributor

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment