New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intended functionality of `Assignment#past_all_due_dates?` with sections enabled #1926

Open
kubasub opened this Issue Dec 4, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@kubasub
Contributor

kubasub commented Dec 4, 2014

There are two pending RSpec test in the Assignment model spec that are both related to the Assignment#past_all_due_dates? method.

It is unclear whether or not past_all_due_dates? should also check the assignment's due_date attribute when section's are enabled.

Options
  1. If every student does not need to be assigned to a section (with it's own SectionDueDate), then the method should also check the assignment's due_date as that is the due date those students would go by.
  2. If every student needs to be assigned to a section when sections are enabled, then the method should most likely not check the assignment's due_date as every student will have a SectionDueDate to go by.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment