New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Assignment file tests to machinist #247

Closed
NelleV opened this Issue Feb 6, 2011 · 6 comments

Comments

Projects
None yet
3 participants
@NelleV
Member

NelleV commented Feb 6, 2011

These tests are still using fixtures. They need to be migrated to Machinist.

@ghost ghost assigned NelleV Aug 18, 2011

@cy

This comment has been minimized.

Show comment
Hide comment
@cy

cy Feb 13, 2012

Member

I will work on this. I'm still quite unsure how tests are done for this project and in rails in general, so I do some reading up on fixtures and machinist first.

Member

cy commented Feb 13, 2012

I will work on this. I'm still quite unsure how tests are done for this project and in rails in general, so I do some reading up on fixtures and machinist first.

@NelleV

This comment has been minimized.

Show comment
Hide comment
@NelleV

NelleV Feb 13, 2012

Member

If you need any help, don't hesitate to ask me.

Member

NelleV commented Feb 13, 2012

If you need any help, don't hesitate to ask me.

@ghost ghost assigned cy Feb 13, 2012

@cy

This comment has been minimized.

Show comment
Hide comment
@cy

cy Feb 14, 2012

Member

Will do, thanks Nelle!

Member

cy commented Feb 14, 2012

Will do, thanks Nelle!

@cy

This comment has been minimized.

Show comment
Hide comment
@cy

cy Feb 21, 2012

Member

Hey @NelleV, does this issue reference the file test/functional/assignments_controller_test.rb? At a glance, it seems to already use Machinist - sorry for the newbie question.

Member

cy commented Feb 21, 2012

Hey @NelleV, does this issue reference the file test/functional/assignments_controller_test.rb? At a glance, it seems to already use Machinist - sorry for the newbie question.

@cy

This comment has been minimized.

Show comment
Hide comment
@cy

cy Apr 9, 2012

Member

@NelleV I'm not sure if this ticket was a dup of issue 244 you closed last year. I've made a minor change to the test any way at http://review.markusproject.org/r/1223/ if you would like to have a look.

Member

cy commented Apr 9, 2012

@NelleV I'm not sure if this ticket was a dup of issue 244 you closed last year. I've made a minor change to the test any way at http://review.markusproject.org/r/1223/ if you would like to have a look.

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Jul 29, 2013

Member

Closed with #1144 thanks to @ghigt

Member

benjaminvialle commented Jul 29, 2013

Closed with #1144 thanks to @ghigt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment