Replace prototype legacy with new code #475

Closed
jerboaa opened this Issue Sep 9, 2011 · 8 comments

Comments

Projects
None yet
6 participants
@jerboaa
Member

jerboaa commented Sep 9, 2011

We are using prototype_legacy_helper[1] in order to be able to use some Rails 2 only things in Rails 3. We need to update our code so as to not use any functions listed in [1] anymore. In theory it should work to replace code with code in the legacy helper.

[1] https://github.com/rails/prototype_legacy_helper/blob/master/lib/prototype_legacy_helper.rb

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Sep 9, 2011

Member

Note that prototype_legacy_helper is no longer maintained.

Member

jerboaa commented Sep 9, 2011

Note that prototype_legacy_helper is no longer maintained.

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Sep 10, 2011

Member

I totally agree on this point !

Member

benjaminvialle commented Sep 10, 2011

I totally agree on this point !

@daneshd

This comment has been minimized.

Show comment
Hide comment
@daneshd

daneshd Jan 31, 2012

Contributor

I'll take a spin at this.

Contributor

daneshd commented Jan 31, 2012

I'll take a spin at this.

@hansonwu

This comment has been minimized.

Show comment
Hide comment
@hansonwu

hansonwu Feb 12, 2012

Contributor

Splitting the link_to_remote work up:
I am taking assignments, graders, results, rubrics. Danesh will take the rest.

Contributor

hansonwu commented Feb 12, 2012

Splitting the link_to_remote work up:
I am taking assignments, graders, results, rubrics. Danesh will take the rest.

@jeffling

This comment has been minimized.

Show comment
Hide comment
@jeffling

jeffling Jul 20, 2012

Member

@hansonwu Do you have any unpushed changes related to this issue?

Member

jeffling commented Jul 20, 2012

@hansonwu Do you have any unpushed changes related to this issue?

@ioev

This comment has been minimized.

Show comment
Hide comment
@ioev

ioev Oct 22, 2012

Contributor

Since this issue is still open and hasn't been looked at in a few months, it can be assigned to me and I'll take a look at switching over any remaining legacy functions.

Contributor

ioev commented Oct 22, 2012

Since this issue is still open and hasn't been looked at in a few months, it can be assigned to me and I'll take a look at switching over any remaining legacy functions.

@ghost ghost assigned ioev Oct 23, 2012

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Oct 23, 2012

Member

Thanks for taking care of this one :)

Member

benjaminvialle commented Oct 23, 2012

Thanks for taking care of this one :)

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Nov 28, 2012

Member

Let's close this for good :) PR #933 should have been the last step. New issues for what's left please.

Member

jerboaa commented Nov 28, 2012

Let's close this for good :) PR #933 should have been the last step. New issues for what's left please.

@jerboaa jerboaa closed this Nov 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment