Repository browser is broken #500

Closed
jerboaa opened this Issue Sep 26, 2011 · 7 comments

Comments

Projects
None yet
7 participants
@jerboaa
Member

jerboaa commented Sep 26, 2011

At the moment it's not possible to browse for different revisions or collect a submission when using the repository browser (as an admin).

@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Jan 22, 2012

Member

It currently seems to work for collecting submissions, but we can't get to the grader view.

Member

reidka commented Jan 22, 2012

It currently seems to work for collecting submissions, but we can't get to the grader view.

@cy

This comment has been minimized.

Show comment
Hide comment
@cy

cy Jan 22, 2012

Member

I am (attempting) to work on this for getting to the grader view.

Member

cy commented Jan 22, 2012

I am (attempting) to work on this for getting to the grader view.

@ghost ghost assigned cy Jan 22, 2012

@cy

This comment has been minimized.

Show comment
Hide comment
@cy

cy Jan 24, 2012

Member

I think commit #695464f by @benjaminvialle fixed this issue. Although once at the grader view, the submission seems to be stuck on "Loading Code..." -> separate issue?

Member

cy commented Jan 24, 2012

I think commit #695464f by @benjaminvialle fixed this issue. Although once at the grader view, the submission seems to be stuck on "Loading Code..." -> separate issue?

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Jan 24, 2012

Member

Yes, it is a separate issue.

Don't know if it is the collection process failing or something else.

Two french students are investigating.

Member

benjaminvialle commented Jan 24, 2012

Yes, it is a separate issue.

Don't know if it is the collection process failing or something else.

Two french students are investigating.

@daneshd

This comment has been minimized.

Show comment
Hide comment
@daneshd

daneshd Feb 5, 2012

Contributor

No, 695464f did not fix the issue. I was working on #441 and found a fix for it.

Collecting the submission is fixable by changing manually_collect_and_begin_grading to post (instead of get) in the routes file.

After collecting it though, the page doesn't redirect to the results page for viewing the submission. I noticed my server kept running update_converted_pdfs (in submissions_controller) while browsing repos. It also tries to run this after manually_collect_and_begin_grading - perhaps this is the problem? It doesn't know where to go from there.

If the 2 are separate issues, have we opened one for it? I'll comment on there instead. For now I'll just write a review for collecting.

Contributor

daneshd commented Feb 5, 2012

No, 695464f did not fix the issue. I was working on #441 and found a fix for it.

Collecting the submission is fixable by changing manually_collect_and_begin_grading to post (instead of get) in the routes file.

After collecting it though, the page doesn't redirect to the results page for viewing the submission. I noticed my server kept running update_converted_pdfs (in submissions_controller) while browsing repos. It also tries to run this after manually_collect_and_begin_grading - perhaps this is the problem? It doesn't know where to go from there.

If the 2 are separate issues, have we opened one for it? I'll comment on there instead. For now I'll just write a review for collecting.

@hoboman313

This comment has been minimized.

Show comment
Hide comment
@hoboman313

hoboman313 Feb 5, 2012

I briefly investigated this as I thought it might be connected to some of my other bugs.

2 more problems:

1.)
ActionView::Template::Error (No route matches {:controller=>"results", :action=>"edit", :id=>27}):
12: else
13: submission_collector.safely_stop_child_exited = false
14: submission_collector.save
15: page.redirect_to :controller => 'results', :action => 'edit',
16: :id => @grouping.current_submission_used.result.id
17: end
18: end
app/views/submissions/update_converted_pdfs.rjs:15:in _app_views_submissions_update_converted_pdfs_rjs___311861420__628320208_0' app/views/submissions/update_converted_pdfs.rjs:1:in_app_views_submissions_update_converted_pdfs_rjs___311861420__628320208_0'

Rendered /var/lib/gems/1.8/gems/actionpack-3.0.10/lib/action_dispatch/middleware/templates/rescues/_trace.erb (2.6ms)
Rendered /var/lib/gems/1.8/gems/actionpack-3.0.10/lib/action_dispatch/middleware/templates/rescues/_request_and_response.erb (28.5ms)
Rendered /var/lib/gems/1.8/gems/actionpack-3.0.10/lib/action_dispatch/middleware/templates/rescues/template_error.erb within rescues/layout (38.5ms)

2.) incorrect routing for update_converted_pdfs
I believe it needs a get and post routing

I briefly investigated this as I thought it might be connected to some of my other bugs.

2 more problems:

1.)
ActionView::Template::Error (No route matches {:controller=>"results", :action=>"edit", :id=>27}):
12: else
13: submission_collector.safely_stop_child_exited = false
14: submission_collector.save
15: page.redirect_to :controller => 'results', :action => 'edit',
16: :id => @grouping.current_submission_used.result.id
17: end
18: end
app/views/submissions/update_converted_pdfs.rjs:15:in _app_views_submissions_update_converted_pdfs_rjs___311861420__628320208_0' app/views/submissions/update_converted_pdfs.rjs:1:in_app_views_submissions_update_converted_pdfs_rjs___311861420__628320208_0'

Rendered /var/lib/gems/1.8/gems/actionpack-3.0.10/lib/action_dispatch/middleware/templates/rescues/_trace.erb (2.6ms)
Rendered /var/lib/gems/1.8/gems/actionpack-3.0.10/lib/action_dispatch/middleware/templates/rescues/_request_and_response.erb (28.5ms)
Rendered /var/lib/gems/1.8/gems/actionpack-3.0.10/lib/action_dispatch/middleware/templates/rescues/template_error.erb within rescues/layout (38.5ms)

2.) incorrect routing for update_converted_pdfs
I believe it needs a get and post routing

daneshd added a commit to daneshd/Markus that referenced this issue Mar 4, 2012

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Jul 15, 2012

Contributor

It doesn't look like there has been any progress on browsing different revision. I can work on that part.

Contributor

mikeing2001 commented Jul 15, 2012

It doesn't look like there has been any progress on browsing different revision. I can work on that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment