New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predefined annotations not showing up for PDF submission #567

Closed
fpitt opened this Issue Oct 19, 2011 · 16 comments

Comments

Projects
None yet
5 participants
@fpitt

fpitt commented Oct 19, 2011

I'm using MarkUs for PDF submissions this term (in CSC165H1F) and one issue that my markers have run into is that for most PDF submissions, MarkUs does not display the list of predefined annotations at the top. This means that my markers have to manually enter all of their annotations for most submissions— clearly not a desirable situation!
This looks as though it may be a UI issue: the list of annotations does seem to get displayed for a fraction of a second, but then the PDF is overlaid right on top of it and the annotations become inaccessible.
I'd be happy to demonstrate this if it would help.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Nov 2, 2011

Member

#104 is likely the same issue.

Member

jerboaa commented Nov 2, 2011

#104 is likely the same issue.

@fpitt

This comment has been minimized.

Show comment
Hide comment
@fpitt

fpitt Nov 2, 2011

Agreed: this is the same issue.
The one thing I found interesting is that it looks like the annotations really are there but get "covered up" by the image so that they become inaccessible.

fpitt commented Nov 2, 2011

Agreed: this is the same issue.
The one thing I found interesting is that it looks like the annotations really are there but get "covered up" by the image so that they become inaccessible.

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Nov 7, 2011

Member

just for information : the patch for the new way of annotating images (the branch called tablet in my repo) add annotation categories for images.

This branch needs some fixes and then it'll be ready to go :)

Member

benjaminvialle commented Nov 7, 2011

just for information : the patch for the new way of annotating images (the branch called tablet in my repo) add annotation categories for images.

This branch needs some fixes and then it'll be ready to go :)

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Nov 7, 2011

Member

Are you saying it's fixed there, Benjamin?

Member

jerboaa commented Nov 7, 2011

Are you saying it's fixed there, Benjamin?

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Nov 9, 2011

Member

Yes. But the code hasn't been tested with Rails 3 yet…

Member

benjaminvialle commented Nov 9, 2011

Yes. But the code hasn't been tested with Rails 3 yet…

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Nov 10, 2011

Member

Thanks for clarifying, Benjamin.

Member

jerboaa commented Nov 10, 2011

Thanks for clarifying, Benjamin.

@Alexandra-G

This comment has been minimized.

Show comment
Hide comment
@Alexandra-G

Alexandra-G Jun 26, 2012

So is there a fix? I am also running into this problem when teaching CSC165H1Y

Alexandra-G commented Jun 26, 2012

So is there a fix? I am also running into this problem when teaching CSC165H1Y

@mina

This comment has been minimized.

Show comment
Hide comment
@mina

mina Aug 9, 2012

Contributor

I will take a look, and I will ask to be assigned if I think I can fix :)

Contributor

mina commented Aug 9, 2012

I will take a look, and I will ask to be assigned if I think I can fix :)

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Aug 13, 2012

Member

@mina You can have a look, if you want, to my branch : https://github.com/benjaminvialle/Markus/tree/tablet

We implemented a SVG alternative for annotating images. It may need some fixes but it is very close to be merged :)

Member

benjaminvialle commented Aug 13, 2012

@mina You can have a look, if you want, to my branch : https://github.com/benjaminvialle/Markus/tree/tablet

We implemented a SVG alternative for annotating images. It may need some fixes but it is very close to be merged :)

@mina

This comment has been minimized.

Show comment
Hide comment
@mina

mina Aug 13, 2012

Contributor

Sweet I will, but can you look at the diff in #826?

It seems that all the problem with this bug is that the annotation menu is being hidden. I simply found and removed the code that hides the menu and it seems to be working now. I am wondering if that commit fixes the problem or there is a deeper issue I am not aware of.

Contributor

mina commented Aug 13, 2012

Sweet I will, but can you look at the diff in #826?

It seems that all the problem with this bug is that the annotation menu is being hidden. I simply found and removed the code that hides the menu and it seems to be working now. I am wondering if that commit fixes the problem or there is a deeper issue I am not aware of.

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Aug 13, 2012

Member

I don't know. I will try to test your code as soon as possible.

Member

benjaminvialle commented Aug 13, 2012

I don't know. I will try to test your code as soon as possible.

benjaminvialle added a commit to benjaminvialle/Markus that referenced this issue Aug 13, 2012

Merge branch 'master' of github.com:benjaminvialle/Markus into tablet
Related to #567 Predefined annotations not showing up for PDF submission
@mina

This comment has been minimized.

Show comment
Hide comment
@mina

mina Aug 13, 2012

Contributor

sounds good, no rush.

Contributor

mina commented Aug 13, 2012

sounds good, no rush.

@mina

This comment has been minimized.

Show comment
Hide comment
@mina

mina Aug 15, 2012

Contributor

Hmm @benjaminvialle I checked out your branch but I get this error when I try to look at an image in the marking to investigate this issue:

Could not render this file in the code viewer. Click on the Download button to download the file instead.

Is this a known issue? Maybe something wrong with my setup.

Contributor

mina commented Aug 15, 2012

Hmm @benjaminvialle I checked out your branch but I get this error when I try to look at an image in the marking to investigate this issue:

Could not render this file in the code viewer. Click on the Download button to download the file instead.

Is this a known issue? Maybe something wrong with my setup.

@mina mina referenced this issue Aug 16, 2012

Merged

Image annot #831

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Aug 17, 2012

Member

Hi @mina

Hum, it looks like it is an error.
You don't have a more explaining message in logs ?

Member

benjaminvialle commented Aug 17, 2012

Hi @mina

Hum, it looks like it is an error.
You don't have a more explaining message in logs ?

@mina

This comment has been minimized.

Show comment
Hide comment
@mina

mina Aug 17, 2012

Contributor

That error is an alert actually. When I close that alert I get another alert:

No route matches {:action=>"view_image_annotations", :submission_file_id=>"194", :controller=>"annotations"}

No errors in console.

However, take a look at pull request #831. I believe I completely fixed this bug for the master branch. Maybe it will work for your tablet branch too? Otherwise if you open a ticket I can look at the tablet branch and fix the issue there as well.

Contributor

mina commented Aug 17, 2012

That error is an alert actually. When I close that alert I get another alert:

No route matches {:action=>"view_image_annotations", :submission_file_id=>"194", :controller=>"annotations"}

No errors in console.

However, take a look at pull request #831. I believe I completely fixed this bug for the master branch. Maybe it will work for your tablet branch too? Otherwise if you open a ticket I can look at the tablet branch and fix the issue there as well.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Sep 12, 2012

Member

@mina says #831 fixes this, so I'm closing. Feel free to reopen if you think that's a mistake!

Member

jerboaa commented Sep 12, 2012

@mina says #831 fixes this, so I'm closing. Feel free to reopen if you think that's a mistake!

@jerboaa jerboaa closed this Sep 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment