Inconsistent cancel button positioning #610

Closed
hoboman313 opened this Issue Jan 21, 2012 · 5 comments

Comments

Projects
None yet
6 participants
@hoboman313

In some of the views there is a pair of "submit", "cancel" buttons where the "submit" button is first and the "cancel" button is to its immediate right. In certain dialogs the order is reversed where the " action " button is shown after the "cancel" button.

The dialogs and views should be consistent with the positioning of the "cancel" button. I believe that the microsoft standard is to have it last, but don't quote me on that.

Steps to reproduce:

  1. login as a user
  2. go to submissions
  3. note the "submit" and "cancel" buttons
  4. click "add new", then browse
  5. note how the "cancel" button in the dialog is now first
  6. same as above, go to submissions and hit the "cancel" button
  7. note how the "cancel" button in the dialog is first
@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Jan 22, 2012

Member

Very good observation and report. Feel free to provide a fix :)

Member

jerboaa commented Jan 22, 2012

Very good observation and report. Feel free to provide a fix :)

@seanbud

This comment has been minimized.

Show comment
Hide comment
@seanbud

seanbud Jan 22, 2012

Contributor

This bug looks like a good spot to start!

i'm going to start working on it.

*EDIT:

This is a bit tougher than i thought, i'm not working on it now.

I've been able to replicate this bug on Ubuntu, and Mac OS, but it seems that this bug might not occur on Windows.

this is because the layout of the "OK CANCEL" forms on any specific platform will follow a style guide. The browser will also follow this style.

PICTURE OF BUG:

http://postimage.org/image/yequwn1x3/

SUGGESTION FOR FIX:

Detect the operating system of the user and build the css for the entire site according to the appropriate style guide.

Contributor

seanbud commented Jan 22, 2012

This bug looks like a good spot to start!

i'm going to start working on it.

*EDIT:

This is a bit tougher than i thought, i'm not working on it now.

I've been able to replicate this bug on Ubuntu, and Mac OS, but it seems that this bug might not occur on Windows.

this is because the layout of the "OK CANCEL" forms on any specific platform will follow a style guide. The browser will also follow this style.

PICTURE OF BUG:

http://postimage.org/image/yequwn1x3/

SUGGESTION FOR FIX:

Detect the operating system of the user and build the css for the entire site according to the appropriate style guide.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Jan 22, 2012

Member

Thanks @seanbud The inconsistency seems to be due to JS alert() dialogs, which are provided by the browser. Your suggestion is good, but it's not very high priority. Perhaps it's best to work on something else for starters :)

Member

jerboaa commented Jan 22, 2012

Thanks @seanbud The inconsistency seems to be due to JS alert() dialogs, which are provided by the browser. Your suggestion is good, but it's not very high priority. Perhaps it's best to work on something else for starters :)

@ghost ghost assigned ghigt Jun 8, 2013

@ghigt

This comment has been minimized.

Show comment
Hide comment
@ghigt

ghigt Jun 28, 2013

Member

IMO, it's not possible to reverse buttons ok and cancel in a confirm() window.

Is it really an issue for you ?

Member

ghigt commented Jun 28, 2013

IMO, it's not possible to reverse buttons ok and cancel in a confirm() window.

Is it really an issue for you ?

@arkon

This comment has been minimized.

Show comment
Hide comment
@arkon

arkon May 13, 2014

Member

Yeah, this is due to the different OSs and their own design patterns. Not sure if we can really "fix" this issue?

Member

arkon commented May 13, 2014

Yeah, this is due to the different OSs and their own design patterns. Not sure if we can really "fix" this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment