New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup message for IE users #617

Closed
reidka opened this Issue Jan 26, 2012 · 6 comments

Comments

Projects
None yet
6 participants
@reidka
Member

reidka commented Jan 26, 2012

Since many functions don't work in IE, it would be help to identify when a user is trying to use MarkUs with IE and warning them that they may have trouble and should switch to Firefox.

@seanbud

This comment has been minimized.

Show comment
Hide comment
@seanbud

seanbud Jan 29, 2012

Contributor

I'll grab this one.

Contributor

seanbud commented Jan 29, 2012

I'll grab this one.

@ghost ghost assigned seanbud Feb 5, 2012

@jeffling

This comment has been minimized.

Show comment
Hide comment
@jeffling

jeffling Jun 26, 2012

Member

Hey, unfortunately I use a mac and I don't have old versions of IE. Is this still needed?

Member

jeffling commented Jun 26, 2012

Hey, unfortunately I use a mac and I don't have old versions of IE. Is this still needed?

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Jun 27, 2012

Member

@ummu: FYI: @seanbud had a patch for this a while ago. I was about to update it and propose a PR. See: http://review.markusproject.org/r/1212/

Member

jerboaa commented Jun 27, 2012

@ummu: FYI: @seanbud had a patch for this a while ago. I was about to update it and propose a PR. See: http://review.markusproject.org/r/1212/

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Jun 27, 2012

Member

@ummu: If you are looking for tickets to work on #567 would be a good one. There should be an old fix for it part of the tactile review, which will likely require a forward port to latest master...

Member

jerboaa commented Jun 27, 2012

@ummu: If you are looking for tickets to work on #567 would be a good one. There should be an old fix for it part of the tactile review, which will likely require a forward port to latest master...

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Nov 11, 2012

Member

Here is patch from @seanbud from RB: https://gist.github.com/4055284

Description was:
In this diff I've implemented a javascript alert for any users who are using Microsoft Internet Explorer.

This alert is given on the login screen.

The warning has been written in english and french, but i'm not 100% sure about the french translation (had a friend translate it for me).

Member

benjaminvialle commented Nov 11, 2012

Here is patch from @seanbud from RB: https://gist.github.com/4055284

Description was:
In this diff I've implemented a javascript alert for any users who are using Microsoft Internet Explorer.

This alert is given on the login screen.

The warning has been written in english and french, but i'm not 100% sure about the french translation (had a friend translate it for me).

@danielstjules

This comment has been minimized.

Show comment
Hide comment
@danielstjules

danielstjules Jan 20, 2013

Member

I hadn't noticed this issue until now. I've been working on it a bit and almost have it done. Rather than using a javascript alert as seen in the above posted diff, I'm displaying a modal to the user instead.

Member

danielstjules commented Jan 20, 2013

I hadn't noticed this issue until now. I've been working on it a bit and almost have it done. Rather than using a javascript alert as seen in the above posted diff, I'm displaying a modal to the user instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment