New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript error on the student_interface when viewing an assignment without a valid group #666

Closed
hoboman313 opened this Issue Feb 14, 2012 · 8 comments

Comments

Projects
None yet
4 participants
@hoboman313

hoboman313 commented Feb 14, 2012

Steps to reproduce:

  • create or modify an assignment to required for a student to have a group of 2 to 3
  • login as a student and select that assignment
  • note the javascript and .css errors:

"NetworkError: 404 Not Found - http://localhost:3000/stylesheets/content.css"

and

document.on is not a function
document.on("click", "*[data-confirm]", function(event, element) {

coming from rails.js line: 128

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Feb 15, 2012

Member

Hmm, I'm starting to believe something is wrong with our rails.js. Could it be that there was going something wrong when we upgraded?

Member

jerboaa commented Feb 15, 2012

Hmm, I'm starting to believe something is wrong with our rails.js. Could it be that there was going something wrong when we upgraded?

@hoboman313

This comment has been minimized.

Show comment
Hide comment
@hoboman313

hoboman313 Feb 15, 2012

I think it's too early to say that yet. Further investigation is required for this issue.

hoboman313 commented Feb 15, 2012

I think it's too early to say that yet. Further investigation is required for this issue.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Feb 15, 2012

Member

I'm mentioning this since @tobioboye was experiencing similar weird behaviour if I'm not mistaken.

Member

jerboaa commented Feb 15, 2012

I'm mentioning this since @tobioboye was experiencing similar weird behaviour if I'm not mistaken.

@tobioboye

This comment has been minimized.

Show comment
Hide comment
@tobioboye

tobioboye Feb 20, 2012

Member

Yes I am experiencing some issues that could potentially be an issue with the rails.js code itself. However, they are not similar issues the one I had is the Log In button not being disabled because the AJAX "before" event handler was absent. From the blogs I've been reading up about this "document.on is not a function" issue, it happened in earlier releases of Prototype's rails.js file but hasn't happened in the current Prototype 1.7_rc2

Member

tobioboye commented Feb 20, 2012

Yes I am experiencing some issues that could potentially be an issue with the rails.js code itself. However, they are not similar issues the one I had is the Log In button not being disabled because the AJAX "before" event handler was absent. From the blogs I've been reading up about this "document.on is not a function" issue, it happened in earlier releases of Prototype's rails.js file but hasn't happened in the current Prototype 1.7_rc2

@jeffling

This comment has been minimized.

Show comment
Hide comment
@jeffling

jeffling Jun 10, 2012

Member

I upgraded to prototype 1.7 stable and got the latest rails.js and the error is now

GET http://0.0.0.0:3000/stylesheets/content.css 404 (Not Found) student_interface

Uncaught ReferenceError: Ajax is not defined

Also. is it supposed to be content.css? It doesn't seem like that file exists.

Member

jeffling commented Jun 10, 2012

I upgraded to prototype 1.7 stable and got the latest rails.js and the error is now

GET http://0.0.0.0:3000/stylesheets/content.css 404 (Not Found) student_interface

Uncaught ReferenceError: Ajax is not defined

Also. is it supposed to be content.css? It doesn't seem like that file exists.

@jeffling

This comment has been minimized.

Show comment
Hide comment
@jeffling

jeffling Jun 10, 2012

Member

Alright, by updating Prototype to 1.7 stable and updating to the latest rails.js file, the javascript error is fixed. I'm not sure what's up with the content.css error, is there supposed to be an auto-generated file called content.css? I'm removing it from the header in the next submission and someone can tell me otherwise during review.

http://review.markusproject.org/r/1232/diff/#index_header

Member

jeffling commented Jun 10, 2012

Alright, by updating Prototype to 1.7 stable and updating to the latest rails.js file, the javascript error is fixed. I'm not sure what's up with the content.css error, is there supposed to be an auto-generated file called content.css? I'm removing it from the header in the next submission and someone can tell me otherwise during review.

http://review.markusproject.org/r/1232/diff/#index_header

@jeffling

This comment has been minimized.

Show comment
Hide comment
@jeffling

jeffling Jun 21, 2012

Member

This issue can be closed probably.

Member

jeffling commented Jun 21, 2012

This issue can be closed probably.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Jun 21, 2012

Member

Closing with the assumption that PR #757 fixed the issue for upcoming MarkUs 1.0 (master)

Member

jerboaa commented Jun 21, 2012

Closing with the assumption that PR #757 fixed the issue for upcoming MarkUs 1.0 (master)

@jerboaa jerboaa closed this Jun 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment