New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MarkUs preferences: In order to add custom filters to show/hide columns #689

Closed
aimenk opened this Issue Feb 28, 2012 · 8 comments

Comments

Projects
None yet
6 participants
@aimenk
Contributor

aimenk commented Feb 28, 2012

This is basically a continuation for issue #327 where it was suggested to have a filter just like ReviewBoard which gives you options to hide/ show columns.

I can continue working on this, but any suggestions on how I should go about it would be great.

Has anyone used DropDown Menu class before??

@tobioboye

This comment has been minimized.

Show comment
Hide comment
@tobioboye

tobioboye Feb 28, 2012

Member

For an example of where we used drop down menus, you can take a look the drop down for locale (en, fr) at $PATH_TO_MARKUS/app/views/layouts/_header.html.erb. select_tag was used. This header is displayed on every page once you login.

Member

tobioboye commented Feb 28, 2012

For an example of where we used drop down menus, you can take a look the drop down for locale (en, fr) at $PATH_TO_MARKUS/app/views/layouts/_header.html.erb. select_tag was used. This header is displayed on every page once you login.

@aimenk

This comment has been minimized.

Show comment
Hide comment
@aimenk

aimenk Feb 28, 2012

Contributor

Hi tobi,

I was wondering if you go to Markus / public / javascripts / DropDownMenu
and the class DropDownMenu, if that has been used before in MarkUs?

Would you know anything about it?

Contributor

aimenk commented Feb 28, 2012

Hi tobi,

I was wondering if you go to Markus / public / javascripts / DropDownMenu
and the class DropDownMenu, if that has been used before in MarkUs?

Would you know anything about it?

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Feb 28, 2012

Member

@aimenk For this feature to make sense, we'd need to implement user preferences first. I.e. add a new model and make it a has-one association of the user table. In the new preference model add preferences for submission_table and grouping_table (and perhaps also others for which we want filters.). I suggest for a first step, those prefs are only implicitly modified when the user changes displayed columns in these customizable views.

As for the drop-down I don't think plain select tags will do it. We'd want a drop-down of check boxes. I'm not sure what javascripts/DropDownMenu is about. Perhaps the assignment dropdown selection? In any case I don't think we have anything like that in the UI somewhere already. As you can see, this will be a bigger task. I suggest to come up with a few mock-ups first and a description as to how you see this working. Then put it up on the blog and get feedback. My $0.02

Member

jerboaa commented Feb 28, 2012

@aimenk For this feature to make sense, we'd need to implement user preferences first. I.e. add a new model and make it a has-one association of the user table. In the new preference model add preferences for submission_table and grouping_table (and perhaps also others for which we want filters.). I suggest for a first step, those prefs are only implicitly modified when the user changes displayed columns in these customizable views.

As for the drop-down I don't think plain select tags will do it. We'd want a drop-down of check boxes. I'm not sure what javascripts/DropDownMenu is about. Perhaps the assignment dropdown selection? In any case I don't think we have anything like that in the UI somewhere already. As you can see, this will be a bigger task. I suggest to come up with a few mock-ups first and a description as to how you see this working. Then put it up on the blog and get feedback. My $0.02

@aimenk

This comment has been minimized.

Show comment
Hide comment
@aimenk

aimenk Mar 3, 2012

Contributor

Blog has been posted, please feel free to comment away...

http://blog.markusproject.org/?p=3764

Contributor

aimenk commented Mar 3, 2012

Blog has been posted, please feel free to comment away...

http://blog.markusproject.org/?p=3764

@seanbud

This comment has been minimized.

Show comment
Hide comment
@seanbud

seanbud Mar 10, 2012

Contributor

I have been working on this issue with aimenk, please assign both of us to this issue.

Contributor

seanbud commented Mar 10, 2012

I have been working on this issue with aimenk, please assign both of us to this issue.

@ghost ghost assigned aimenk and seanbud Mar 10, 2012

@tobioboye

This comment has been minimized.

Show comment
Hide comment
@tobioboye

tobioboye Mar 10, 2012

Member

Only one person can be assigned the issue on Github. Your comment is sufficient :)

Member

tobioboye commented Mar 10, 2012

Only one person can be assigned the issue on Github. Your comment is sufficient :)

@ghost ghost assigned aimenk Mar 10, 2012

@e-morency

This comment has been minimized.

Show comment
Hide comment
@e-morency

e-morency Sep 30, 2012

Contributor

@aimenk and @seanbud what's the status on the preferences? I would be willing to work on this (maybe start where you left off), are you still working on it? If not, please let me know :)

Contributor

e-morency commented Sep 30, 2012

@aimenk and @seanbud what's the status on the preferences? I would be willing to work on this (maybe start where you left off), are you still working on it? If not, please let me know :)

@david-yz-liu

This comment has been minimized.

Show comment
Hide comment
@david-yz-liu

david-yz-liu Aug 24, 2014

Contributor

#939 is the main User Preferences issue.

Also note that the table implementation was just changed to React (not that this should make it harder to show/hide columns... @oneohtrix?)

Contributor

david-yz-liu commented Aug 24, 2014

#939 is the main User Preferences issue.

Also note that the table implementation was just changed to React (not that this should make it harder to show/hide columns... @oneohtrix?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment