New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering notes dialog from Users page does not work #696

Closed
daneshd opened this Issue Mar 4, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@daneshd
Contributor

daneshd commented Mar 4, 2012

To reproduce:
1. Login as admin
2. Click on Users
3. Click on any student's Notes link

It's not just a routes problem. I'm working to fix the link_to_remote but the standard changes aren't doing the trick.

Assigning to myself.

@ghost ghost assigned daneshd Mar 4, 2012

@daneshd

This comment has been minimized.

Show comment
Hide comment
@daneshd

daneshd Mar 4, 2012

Contributor

This may be a duplicate of #678, I'll pull Jay's branch and test it out before closing this.

Contributor

daneshd commented Mar 4, 2012

This may be a duplicate of #678, I'll pull Jay's branch and test it out before closing this.

@baadshah02

This comment has been minimized.

Show comment
Hide comment
@baadshah02

baadshah02 Mar 4, 2012

Contributor

All the notes_dialog fixes are in my issue 602. I saw this and I believe it might be because it's doing
:url => note_dialog_note_path() in the file "app/views/users/table_row/_filter_table_row.html.erb". So probably :url => needs to be removed and then combined with the fix for issue 602 should display the notes. You can pull my "edit_groups" branch so you can test it. :)

Contributor

baadshah02 commented Mar 4, 2012

All the notes_dialog fixes are in my issue 602. I saw this and I believe it might be because it's doing
:url => note_dialog_note_path() in the file "app/views/users/table_row/_filter_table_row.html.erb". So probably :url => needs to be removed and then combined with the fix for issue 602 should display the notes. You can pull my "edit_groups" branch so you can test it. :)

@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Aug 2, 2012

Member

closed with pull request #795

Member

reidka commented Aug 2, 2012

closed with pull request #795

@reidka reidka closed this Aug 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment