New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the next/previous file buttons at the start/end of a submission in the GraderView #717

Closed
hoboman313 opened this Issue Mar 13, 2012 · 8 comments

Comments

Projects
None yet
7 participants
@hoboman313

hoboman313 commented Mar 13, 2012

To clarify, I am talking about the "-->" and "<--" arrows in the graderview that may be used to navigate through files in a submission.
Currently if you reach the first/last submission and try to click past it, the arrows will not be disabled; however, they will not do anything when you click on them. This is an annoyance and it would be good to disable them as to show to the user that he/she may not go further.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Mar 13, 2012

Member

Our current stable version has the same behaviour, FWIW.

Member

jerboaa commented Mar 13, 2012

Our current stable version has the same behaviour, FWIW.

@daneshd

This comment has been minimized.

Show comment
Hide comment
@daneshd

daneshd Mar 13, 2012

Contributor

This is probably a link_to_if acting up. It really should be using link_to_if so if it's a ruby if, it should be changed.

Contributor

daneshd commented Mar 13, 2012

This is probably a link_to_if acting up. It really should be using link_to_if so if it's a ruby if, it should be changed.

@hansonwu

This comment has been minimized.

Show comment
Hide comment
@hansonwu

hansonwu Mar 26, 2012

Contributor

If that's true, seems easy enough. I can take this one if no one has started on it!

Contributor

hansonwu commented Mar 26, 2012

If that's true, seems easy enough. I can take this one if no one has started on it!

@hansonwu

This comment has been minimized.

Show comment
Hide comment
@hansonwu

hansonwu Mar 27, 2012

Contributor

Working on this now, it's not a link_to but looks like a quick fix regardless.

Contributor

hansonwu commented Mar 27, 2012

Working on this now, it's not a link_to but looks like a quick fix regardless.

@ghost ghost assigned hansonwu Mar 27, 2012

@hansonwu

This comment has been minimized.

Show comment
Hide comment
@hansonwu

hansonwu Jun 7, 2012

Contributor

Just so nobody starts working on this - I already had a fix, and the fix is sitting in RB for this. Review ID is 1222.

Contributor

hansonwu commented Jun 7, 2012

Just so nobody starts working on this - I already had a fix, and the fix is sitting in RB for this. Review ID is 1222.

@mina

This comment has been minimized.

Show comment
Hide comment
@mina

mina Aug 15, 2012

Contributor

Last update 2 months ago. @hansonwu is this still open?

Contributor

mina commented Aug 15, 2012

Last update 2 months ago. @hansonwu is this still open?

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Nov 11, 2012

Member

Please find a patch from @hansonwu that was previously on RB.

https://gist.github.com/4055200

Description was:

Add UJS to check when at the first or last element in the dropdown, disabling the previous/next buttons when so. Validate when:

  1. Page load
  2. Next or previous is clicked
  3. Selection is made in the dropdown

@Branch 717_next_previous
@github-remote-url git://github.com/hansonwu/Markus.git

Member

benjaminvialle commented Nov 11, 2012

Please find a patch from @hansonwu that was previously on RB.

https://gist.github.com/4055200

Description was:

Add UJS to check when at the first or last element in the dropdown, disabling the previous/next buttons when so. Validate when:

  1. Page load
  2. Next or previous is clicked
  3. Selection is made in the dropdown

@Branch 717_next_previous
@github-remote-url git://github.com/hansonwu/Markus.git

@danielstjules

This comment has been minimized.

Show comment
Hide comment
@danielstjules

danielstjules Oct 6, 2013

Member

Fixed in #1213

Member

danielstjules commented Oct 6, 2013

Fixed in #1213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment