New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download button in edit view gives 404 error #738

Closed
cy opened this Issue Apr 9, 2012 · 4 comments

Comments

Projects
None yet
4 participants
@cy
Member

cy commented Apr 9, 2012

Steps:

  1. Log in as admin
  2. Go to an assignment submission result edit page
  3. Click "Download" button for a submission file
  4. Get 404 Not Found

Started POST "/en/assignments/2/submissions/7/results/download" for 127.0.0.1 at Sun Apr 08 22:48:46 -0700 2012
Processing by MainController#page_not_found as HTML
Parameters: {"authenticity_token"=>"nbwP3xT/dOV4DdhAb63bfrlGphE5ezJQ3Be0QLgGGW0=", "locale"=>"en", "utf8"=>"✓", "commit"=>"Download", "select_file_id"=>"8", "path"=>"assignments/2/submissions/7/results/download"}
Rendered shared/http_status.html.erb (6.7ms)
Completed 404 Not Found in 57ms (Views: 22.7ms | ActiveRecord: 0.0ms)

@daneshd

This comment has been minimized.

Show comment
Hide comment
@daneshd

daneshd Apr 9, 2012

Contributor

There is both a GET and POST route for results/download, I'm guessing we only really want a GET since we aren't saving anything.

Contributor

daneshd commented Apr 9, 2012

There is both a GET and POST route for results/download, I'm guessing we only really want a GET since we aren't saving anything.

@cy

This comment has been minimized.

Show comment
Hide comment
@cy

cy Apr 9, 2012

Member

Think we had the POST route because it's used by form_tag for which the default method is POST?

I found the reason for the 404 though, it's a member route so Rails creates results/:id/download but the download button's path didn't have the id. Posting fix to ReviewBoard in a sec.

Member

cy commented Apr 9, 2012

Think we had the POST route because it's used by form_tag for which the default method is POST?

I found the reason for the 404 though, it's a member route so Rails creates results/:id/download but the download button's path didn't have the id. Posting fix to ReviewBoard in a sec.

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Jul 25, 2012

Contributor

Is there any working being done on this, otherwise I can take over.

Contributor

mikeing2001 commented Jul 25, 2012

Is there any working being done on this, otherwise I can take over.

@cy

This comment has been minimized.

Show comment
Hide comment
@cy

cy Jul 28, 2012

Member

I do have work done on this, but I can't continue until I return from Japan in 2 weeks. Please feel free to take over if you would like.

Member

cy commented Jul 28, 2012

I do have work done on this, but I can't continue until I return from Japan in 2 weeks. Please feel free to take over if you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment