New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment collection and the export file #748

Closed
reidka opened this Issue Jun 11, 2012 · 6 comments

Comments

Projects
None yet
3 participants
@reidka
Member

reidka commented Jun 11, 2012

From Dan Zingaro, a current MarkUs user:

"Prior to the post-grace-day-deadline, I wanted to get my test framework
ready for A1 so that I could start marking as soon as the grace period
lapsed. I therefore briefly changed the due date to be in the past,
collected all submissions, and got the svn export file.

Now that the real deadline has passed, I tried to collect again and get
the svn export file. Except then, two revisions were in the file for
each student. I figured I could learn which of these was newest by once
again collecting, so that there would be three revisions in the export
file per student. But every time I do this, it seems to be putting a
different revision number for each student. Like a student will have a
-r 2, then a -r 4, then a -r 2, etc. every time I collect."

I have seen this before where there are multiple entries for each student in the svn export file.

This may not be associated with grace days at all, but is definitely a problem with assignment collection.

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Jun 13, 2012

Contributor

Can we get more information on how to reproduce this issue. The only time I have been able to see the above behaviour is under the same setup of issue 656. With the current fix I have for issue 656, it does prevent this type of assignment collection changing under the setup of issue 656.

Contributor

mikeing2001 commented Jun 13, 2012

Can we get more information on how to reproduce this issue. The only time I have been able to see the above behaviour is under the same setup of issue 656. With the current fix I have for issue 656, it does prevent this type of assignment collection changing under the setup of issue 656.

@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Jun 14, 2012

Member

Are you looking at the svn export list that is produced from a link in the submissions view? No matter how many times the assignment is collected, there should only be one entry per group in this list.

I'm not sure what you mean by "event this type of assignment collection changing"?

Member

reidka commented Jun 14, 2012

Are you looking at the svn export list that is produced from a link in the submissions view? No matter how many times the assignment is collected, there should only be one entry per group in this list.

I'm not sure what you mean by "event this type of assignment collection changing"?

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Jun 14, 2012

Contributor

From the description from Dan Zingaro, he said that every time he collects the assignment the revision that appears in the svn export list changes. "-r 2, then a -r 4, then a -r 2, etc. every time I collect". I guess I left out a few words in my above comment. I wanted to say is "With the current fix I have for issue 656, it does prevent this type of assignment collection REVISION changing under the setup of issue 656" Meaning i will always get -r 4, then -r4, then -r4 etc. no matter how many times i collected the assignment.

Also, from your above comment "No matter how many times the assignment is collected, there should only be one entry per group in this list.". Is this in reference to Subversion Repo List or Subversion Export File or both?

Contributor

mikeing2001 commented Jun 14, 2012

From the description from Dan Zingaro, he said that every time he collects the assignment the revision that appears in the svn export list changes. "-r 2, then a -r 4, then a -r 2, etc. every time I collect". I guess I left out a few words in my above comment. I wanted to say is "With the current fix I have for issue 656, it does prevent this type of assignment collection REVISION changing under the setup of issue 656" Meaning i will always get -r 4, then -r4, then -r4 etc. no matter how many times i collected the assignment.

Also, from your above comment "No matter how many times the assignment is collected, there should only be one entry per group in this list.". Is this in reference to Subversion Repo List or Subversion Export File or both?

@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Jun 14, 2012

Member

Both. The list we were looking at was the Export File, but it really should apply to both.

There are two points I'd like to clarify:

  1. This bug was identified by collecting an individual assignment revision from the repo view. The button is really intended to force the collection even if the submission rules are not satisfied (e.g., the deadline has not yet passed, the revision in question is after all late penalties) This might be obvious already, but I'd like to make sure that this code path is investigated.

  2. These operations happen over time. So in this case the revision numbers should be changing. For example, if the assignment was collected before the deadline, and then after the deadline, you might get different revisions.

Member

reidka commented Jun 14, 2012

Both. The list we were looking at was the Export File, but it really should apply to both.

There are two points I'd like to clarify:

  1. This bug was identified by collecting an individual assignment revision from the repo view. The button is really intended to force the collection even if the submission rules are not satisfied (e.g., the deadline has not yet passed, the revision in question is after all late penalties) This might be obvious already, but I'd like to make sure that this code path is investigated.

  2. These operations happen over time. So in this case the revision numbers should be changing. For example, if the assignment was collected before the deadline, and then after the deadline, you might get different revisions.

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Jun 21, 2012

Contributor

I'll work on this issue

Contributor

mikeing2001 commented Jun 21, 2012

I'll work on this issue

@ghost ghost assigned mikeing2001 Aug 7, 2012

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Aug 7, 2012

Member

Closed with PR #787.

Member

jerboaa commented Aug 7, 2012

Closed with PR #787.

@jerboaa jerboaa closed this Aug 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment