New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission Page: TA/Admin should be able to hide some columns #788

Closed
lejaokri opened this Issue Jul 5, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@lejaokri
Contributor

lejaokri commented Jul 5, 2012

I could not find a similar issue so I decided to open a new one.
I am currently working on issue #760 which is related to this..

@ghost ghost assigned lejaokri Jul 5, 2012

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Jul 6, 2012

Member

Actually, there's been some work done with regards to user preferences. IMO this would be an instance where we'd like to use user preferences. Have a look at http://review.markusproject.org @aimenk and @seanbud should know more about the status of user prefs.

Member

jerboaa commented Jul 6, 2012

Actually, there's been some work done with regards to user preferences. IMO this would be an instance where we'd like to use user preferences. Have a look at http://review.markusproject.org @aimenk and @seanbud should know more about the status of user prefs.

@lejaokri

This comment has been minimized.

Show comment
Hide comment
@lejaokri

lejaokri Jul 9, 2012

Contributor

Hi Severin,

This is regarding review http://review.markusproject.org/r/1253/ .

Regarding the test, I am using cookies to save the per_page attribute. I
was in the
middle of testing the cookies but unfortunately, the command line that runs
the testcases do not seem to detect cookies.

I also saw the following comments
on test/functional/main_controller_test.rb

#bypass cookie detection in the test because the command line, which is
running the test, cannot accept cookies

*
*
Would it be possible to add to the submission_collector_manual_test_script
instead?

Thanks

On Fri, Jul 6, 2012 at 2:32 AM, Severin Gehwolf <
reply@reply.github.com

wrote:

Actually, there's been some work done with regards to user preferences.
IMO this would be an instance where we'd like to use user preferences. Have
a look at http://review.markusproject.org @aimenk and @seanbud should
know more about the status of user prefs.


Reply to this email directly or view it on GitHub:
#788 (comment)

Kristian Lejao
416-875-8844
kristianlejao@gmail.com

Contributor

lejaokri commented Jul 9, 2012

Hi Severin,

This is regarding review http://review.markusproject.org/r/1253/ .

Regarding the test, I am using cookies to save the per_page attribute. I
was in the
middle of testing the cookies but unfortunately, the command line that runs
the testcases do not seem to detect cookies.

I also saw the following comments
on test/functional/main_controller_test.rb

#bypass cookie detection in the test because the command line, which is
running the test, cannot accept cookies

*
*
Would it be possible to add to the submission_collector_manual_test_script
instead?

Thanks

On Fri, Jul 6, 2012 at 2:32 AM, Severin Gehwolf <
reply@reply.github.com

wrote:

Actually, there's been some work done with regards to user preferences.
IMO this would be an instance where we'd like to use user preferences. Have
a look at http://review.markusproject.org @aimenk and @seanbud should
know more about the status of user prefs.


Reply to this email directly or view it on GitHub:
#788 (comment)

Kristian Lejao
416-875-8844
kristianlejao@gmail.com

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Jul 10, 2012

Member

@lejaokri about that: We should really use user preferences for this. I.e. have a table in the app to store these infos. A cookie isn't supposed to hold much data. Besides it's inconvenient for a user who switched browser or uses two computers to set those preferences multiple times.

Again, it would be best to talk to the folks I've mentioned above and pick up their work and finish it rather than doing this with cookies. My $0.02 :)

Member

jerboaa commented Jul 10, 2012

@lejaokri about that: We should really use user preferences for this. I.e. have a table in the app to store these infos. A cookie isn't supposed to hold much data. Besides it's inconvenient for a user who switched browser or uses two computers to set those preferences multiple times.

Again, it would be best to talk to the folks I've mentioned above and pick up their work and finish it rather than doing this with cookies. My $0.02 :)

@lejaokri

This comment has been minimized.

Show comment
Hide comment
@lejaokri

lejaokri Jul 10, 2012

Contributor

Hi Severin,

I think there's a confusion here. It's my fault as I replied to the wrong email thread. I am talking about issue #293 here. How I can possibly test the cookies.. I am assuming you were talking about issue #788? ( since this thread is regarding issue 788 ). Again sorry for the confusion.

Thanks.

Kristian Lejao
416-875-8844

On 2012-07-10, at 4:28 PM, Severin Gehwolfreply@reply.github.com wrote:

@lejaokri about that: We should really use user preferences for this. I.e. have a table in the app to store these infos. A cookie isn't supposed to hold much data. Besides it's inconvenient for a user who switched browser or uses two computers to set those preferences multiple times.

Again, it would be best to talk to the folks I've mentioned above and pick up their work and finish it rather than doing this with cookies. My $0.02 :)


Reply to this email directly or view it on GitHub:
#788 (comment)

Contributor

lejaokri commented Jul 10, 2012

Hi Severin,

I think there's a confusion here. It's my fault as I replied to the wrong email thread. I am talking about issue #293 here. How I can possibly test the cookies.. I am assuming you were talking about issue #788? ( since this thread is regarding issue 788 ). Again sorry for the confusion.

Thanks.

Kristian Lejao
416-875-8844

On 2012-07-10, at 4:28 PM, Severin Gehwolfreply@reply.github.com wrote:

@lejaokri about that: We should really use user preferences for this. I.e. have a table in the app to store these infos. A cookie isn't supposed to hold much data. Besides it's inconvenient for a user who switched browser or uses two computers to set those preferences multiple times.

Again, it would be best to talk to the folks I've mentioned above and pick up their work and finish it rather than doing this with cookies. My $0.02 :)


Reply to this email directly or view it on GitHub:
#788 (comment)

@lejaokri

This comment has been minimized.

Show comment
Hide comment
@lejaokri

lejaokri Aug 2, 2012

Contributor

@aimenk and @seanbud May I know the status of this issue? Once I found the ticket similar to this, I will close #788.

Contributor

lejaokri commented Aug 2, 2012

@aimenk and @seanbud May I know the status of this issue? Once I found the ticket similar to this, I will close #788.

@lejaokri

This comment has been minimized.

Show comment
Hide comment
@lejaokri

lejaokri Aug 2, 2012

Contributor

Found it.. #689

I am closing 788 because it's a duplicate to 689

Contributor

lejaokri commented Aug 2, 2012

Found it.. #689

I am closing 788 because it's a duplicate to 689

@lejaokri lejaokri closed this Aug 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment