New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grace periods not deducted from students added after the assignment collected #813

Closed
reidka opened this Issue Jul 28, 2012 · 6 comments

Comments

Projects
None yet
3 participants
@reidka
Member

reidka commented Jul 28, 2012

To reproduce:

login as one student, create a group, invite another student, submit a file after at least one grace day
login as admin, collect the assignment
login as second student, accept invitation to join group

switch to users list, notice that second student did not have grace days deducted

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Jul 28, 2012

Contributor

I will work on this

Contributor

mikeing2001 commented Jul 28, 2012

I will work on this

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Jul 29, 2012

Member

This is because we deduct things at collection time. I suppose we need to add something to the accept invitation logic. In case other group members have deductions for the assignment we'd need to create them for the joining student as well.

Member

jerboaa commented Jul 29, 2012

This is because we deduct things at collection time. I suppose we need to add something to the accept invitation logic. In case other group members have deductions for the assignment we'd need to create them for the joining student as well.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Oct 1, 2012

Member

Closed with PR #822.

Member

jerboaa commented Oct 1, 2012

Closed with PR #822.

@jerboaa jerboaa closed this Oct 1, 2012

@jerboaa jerboaa reopened this Oct 25, 2012

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Dec 3, 2012

Member

@mikeing2001 Are you aware of the test failures? Could it be that this is happening on mysql only?

Member

jerboaa commented Dec 3, 2012

@mikeing2001 Are you aware of the test failures? Could it be that this is happening on mysql only?

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Dec 3, 2012

Contributor

I'm aware of this issue but i can't figure out why it is failing. The failing rate really depends. I have had the test case pass multiple times then fail or fail multiple times and then pass. This doesn't seems like a database issue more like a timing issue but i have looked at it many times and can't figure it out.

Contributor

mikeing2001 commented Dec 3, 2012

I'm aware of this issue but i can't figure out why it is failing. The failing rate really depends. I have had the test case pass multiple times then fail or fail multiple times and then pass. This doesn't seems like a database issue more like a timing issue but i have looked at it many times and can't figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment