Assignment Marks Not Updating Consistently #851

Closed
joelburford opened this Issue Sep 29, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@joelburford
Contributor

joelburford commented Sep 29, 2012

Logged in as administrator, navigated to assignments, submissions, then clicked on a group's name to open their assignment. The marking rubric on the right is not working consistently.

Generally when you click on a mark the criteria will collapse and after a few seconds the mark you gave it appears underneath the title. Sometimes the mark does not update, and a 404 message appears in the console.

Started POST "/en/assignments/1/submissions/1/results/update_mark?mark=2&mark_id=2" for 127.0.0.1 at Sat Sep 29 11:15:04 -0400 2012
Processing by MainController#page_not_found as JS
Parameters: {"authenticity_token"=>"mMqmPOnow9FBgwnPBMYMVKqdJbrdpi6UCS0dTiRnrPc=", "mark_id"=>"2", "mark"=>"2", "path"=>"assignments/1/submissions/1/results/update_mark", "locale"=>"en"}
Rendered shared/http_status.html.erb (1.8ms)
Completed 404 Not Found in 13ms (Views: 6.4ms | ActiveRecord: 0.0ms)

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Oct 15, 2012

Contributor

I did some investigation on this issue. The issue is when you click on the a mark criteria there are 2 ways for the marks to get updated.

  1. Clicking anywhere in the box. This performed an AJAX Request
  2. Click on the BOLD title. This performed a link_to.

However, the issue at hand is that they both called update_mark_assignment_submission_results_path(). This should have been fine but the Ajax Request was expecting a POST while link_to was expecting a GET. In routes.rb there was only a GET defined. Thus causing it to work only some time.

What needs to be done is remove one of the calls (the link_to one) as i really don't see the point of having both and update the AJAX call to be a GET request and it should solve it.

The file that you should be looking at is _marker_rubric_criterion_li.html.erb in \app\views\results\marker

Contributor

mikeing2001 commented Oct 15, 2012

I did some investigation on this issue. The issue is when you click on the a mark criteria there are 2 ways for the marks to get updated.

  1. Clicking anywhere in the box. This performed an AJAX Request
  2. Click on the BOLD title. This performed a link_to.

However, the issue at hand is that they both called update_mark_assignment_submission_results_path(). This should have been fine but the Ajax Request was expecting a POST while link_to was expecting a GET. In routes.rb there was only a GET defined. Thus causing it to work only some time.

What needs to be done is remove one of the calls (the link_to one) as i really don't see the point of having both and update the AJAX call to be a GET request and it should solve it.

The file that you should be looking at is _marker_rubric_criterion_li.html.erb in \app\views\results\marker

jerboaa added a commit that referenced this issue Oct 25, 2012

Merge pull request #902 from joelburford/issue-851
Fixing UI for updating mark on rubric, issue #851
@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Oct 25, 2012

Member

Closed with PR #902.

Member

jerboaa commented Oct 25, 2012

Closed with PR #902.

@jerboaa jerboaa closed this Oct 25, 2012

@ghost ghost assigned joelburford Oct 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment