New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of mark-up related errors in functional tests. #866

Closed
ioev opened this Issue Sep 30, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@ioev
Contributor

ioev commented Sep 30, 2012

In the functional tests, there are a bunch of warnings showing up that look like:

ignoring attempt to close body with div
    opened at byte 1132, line 18
    closed at byte 28221, line 542
    attributes at open: {}
    text around open: "script>\n  \n</head>\n\n<body>\n  <div id=\"lo"
    text around close: " <!-- container -->\n</div>\n\n</body>\n</ht"

The warnings seem to relate to the use of .html_safe,
/app/views/assignments/_form.html.erb line 221 is one culprit,

and there is at least one more. Should be an easy fix if you can figure out where to look. It also looks like (to me) that .html_safe isn't really necessary to use in these cases.

Some info on raw() and .html_safe and how it affects string escaping:
http://yehudakatz.com/2010/02/01/safebuffers-and-rails-3-0/

@ioev

This comment has been minimized.

Show comment
Hide comment
@ioev

ioev Sep 30, 2012

Contributor

I'm already looking at fixing this, if someone could assign it to me.

Contributor

ioev commented Sep 30, 2012

I'm already looking at fixing this, if someone could assign it to me.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Oct 18, 2012

Member

Closed with PR #889

Member

jerboaa commented Oct 18, 2012

Closed with PR #889

@jerboaa jerboaa closed this Oct 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment