New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove new submission rule fields during assignment creation #958

Closed
m-bodmer opened this Issue Jan 19, 2013 · 4 comments

Comments

Projects
None yet
4 participants
@m-bodmer
Contributor

m-bodmer commented Jan 19, 2013

When adding new fields to sections under Submission Rules, the user is unable to remove them and the page scrolls to the top of the screen.

Steps to reproduce:

  1. Add a new grace period field
  2. Try to remove the field using remove

This issue also applies to the other two radio buttons for Penalty Decay and Penalty Formula.

Cannot remove fields

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Jan 19, 2013

Contributor

Beware this issue was due to the update of rails. Also there are many other cases similar to this. Pretty much all the remove buttons don't work anymore particularly anyone with this code format <%= link_to_function t(:remove), "$(this).up('.xxx').remove()" %>.

Contributor

mikeing2001 commented Jan 19, 2013

Beware this issue was due to the update of rails. Also there are many other cases similar to this. Pretty much all the remove buttons don't work anymore particularly anyone with this code format <%= link_to_function t(:remove), "$(this).up('.xxx').remove()" %>.

@yc2lee

This comment has been minimized.

Show comment
Hide comment
@yc2lee

yc2lee Jan 19, 2013

Contributor

If I change up('.xxx') to up(".xxx") then the boxes can close properly

Looking into this.................

Contributor

yc2lee commented Jan 19, 2013

If I change up('.xxx') to up(".xxx") then the boxes can close properly

Looking into this.................

@yc2lee

This comment has been minimized.

Show comment
Hide comment
@yc2lee

yc2lee Jan 19, 2013

Contributor

I observed that if you create a brand new assignment, fill in the due date, then add grace periods, it does not refresh the "From" and "To" fields. When I set the due date, my Firefox's Web Console reports the error

[18:39:22.864] grace_periods is null @ http://localhost:3000/javascripts/create_assignment.js?1358392858:201
Contributor

yc2lee commented Jan 19, 2013

I observed that if you create a brand new assignment, fill in the due date, then add grace periods, it does not refresh the "From" and "To" fields. When I set the due date, my Firefox's Web Console reports the error

[18:39:22.864] grace_periods is null @ http://localhost:3000/javascripts/create_assignment.js?1358392858:201
@reidka

This comment has been minimized.

Show comment
Hide comment
@reidka

reidka Jan 25, 2013

Member

closed by pull request #975

Member

reidka commented Jan 25, 2013

closed by pull request #975

@reidka reidka closed this Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment