New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new assignment -- Indicate Required Fields #98

Closed
benjaminvialle opened this Issue Sep 29, 2010 · 9 comments

Comments

Projects
None yet
5 participants
@benjaminvialle
Member

benjaminvialle commented Sep 29, 2010

Where: Assignments > Create new assignment

User has no way of telling which fields are mandatory at the time they're creating a new assignment -- unless they try to proceed. When the user tries to submit the form, they are prompted and told which fields cannot be left blank.

User should know which fields are mandatory as they are filling out the form, not after.

@aimenk

This comment has been minimized.

Show comment
Hide comment
@aimenk

aimenk Feb 4, 2012

Contributor

Hey,

Can you provide more details? I would like to work on this.

Contributor

aimenk commented Feb 4, 2012

Hey,

Can you provide more details? I would like to work on this.

@darynl

This comment has been minimized.

Show comment
Hide comment
@darynl

darynl Jun 10, 2012

Contributor

Could you list the fields which should be required so that I know which ones can be displayed as required?

Contributor

darynl commented Jun 10, 2012

Could you list the fields which should be required so that I know which ones can be displayed as required?

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Jun 11, 2012

Member

I don't have the list but mandatory fields can be seen in rails models.

For example, in app/models/assignment.rb :

validates_presence_of :repository_folder
validates_presence_of :short_identifier, :group_min
validates_uniqueness_of :short_identifier, :case_sensitive => true
Member

benjaminvialle commented Jun 11, 2012

I don't have the list but mandatory fields can be seen in rails models.

For example, in app/models/assignment.rb :

validates_presence_of :repository_folder
validates_presence_of :short_identifier, :group_min
validates_uniqueness_of :short_identifier, :case_sensitive => true
@darynl

This comment has been minimized.

Show comment
Hide comment
@darynl

darynl Jul 5, 2012

Contributor

alright, I'm on it thanks.

Contributor

darynl commented Jul 5, 2012

alright, I'm on it thanks.

@ghost ghost assigned darynl Jul 5, 2012

@mina

This comment has been minimized.

Show comment
Hide comment
@mina

mina Aug 8, 2012

Contributor

@Fudge21 are you still doing this? I can take a look if you don't mind.

Contributor

mina commented Aug 8, 2012

@Fudge21 are you still doing this? I can take a look if you don't mind.

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Aug 9, 2012

Member

Closed with PR #787. Feel free to reopen if you think that's wrong.

Member

jerboaa commented Aug 9, 2012

Closed with PR #787. Feel free to reopen if you think that's wrong.

@jerboaa jerboaa closed this Aug 9, 2012

@darynl

This comment has been minimized.

Show comment
Hide comment
@darynl

darynl Aug 15, 2012

Contributor

It doesn't seem to be related since this issue is a UI issue. I submitted a PR but it was closed cus it was kind of messy. I will re-request a pull request. Please open again

Contributor

darynl commented Aug 15, 2012

It doesn't seem to be related since this issue is a UI issue. I submitted a PR but it was closed cus it was kind of messy. I will re-request a pull request. Please open again

@darynl darynl referenced this issue Aug 15, 2012

Merged

Issue 98 fix #829

@jerboaa jerboaa reopened this Aug 15, 2012

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Aug 15, 2012

Member

Reopened. Thanks!

Member

jerboaa commented Aug 15, 2012

Reopened. Thanks!

@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Aug 17, 2012

Member

Now fixed with PR #829

Member

jerboaa commented Aug 17, 2012

Now fixed with PR #829

@jerboaa jerboaa closed this Aug 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment