Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
FIX for issue 938, added remark request count on dashboard #1011
After clicking the oustanding remark requests link, I was taken to the assignments page but the ordering, although indicated as sort on marking state, was not ordered correctly.
Note: Even clicking the marking state column (twice - once to reverse, once to get desired ordering) does not order the table properly.
Also noticed that if you navigate to the submissions tab not using the dashboard remark request link (eg: click the submissions tab again even though it will just show the same page), the sorting changes to sorting on Group Name although the arrows indicate that it should be sorted by marking state.
I'm not sure if we want this page to always sort on Group Name and for the link to remark requests be an exception to this or if the page should remain sorted as whatever was previously shown.
I noticed the sorting problem too. It is a separate issue I think, so I'll log it soon and fix it later.
I thought the link on remark requests should take the user to a list of remark requests, and grouping them together on submission page, i.e. sorting by marking state, is one way to achieve that. Does that behaviour cause inconvenience or confusion to the user?
I noticed that the sorting problem does still occur before your fix too.
I would think it would be helpful to have it sorted by marking state when the user clicks the link for outstanding remark requests. My point about the second concern I brought up was more about the sorting in general. Eg: After the user clicks the link, should any subsequent visits to the submission tab (not via that outstanding remark request link) display the list still sorted in Marking State/last column sorted by or should it return to the default sort on Group Name? It looks like currently we do not use the last column sorted by when displaying this view, but the bug is that it is not updating those arrows that indicate which column it is sorting by. Since this is also a bug that exists before your change, maybe you want to handle it in a separate issue like the sorting problem? If so, the rest of fix functionality looks good to me.