FIX for issue 938, added remark request count on dashboard #1011

Merged
merged 10 commits into from Mar 2, 2013

Conversation

Projects
None yet
5 participants
@m-wu
Contributor

m-wu commented Feb 21, 2013

Added a message to the dashboard that indicates the number of outstanding remark requests for each assignment. The message is not shown if there isn't any request. The message links to the assignment submissions page, sorted by marking state.

French translations for the messages are needed.

Screenshot from 2013-02-20 09:33:59

config/locales/fr.yml
@@ -1073,6 +1073,8 @@ fr:
assignments_submitted: "Projets envoyés :"
assignments_graded: "Projets corrigés :"
refresh_graph: "Actualiser le graphique"
+ outstanding_remark_request: "%{request_count} outstanding remark request"

This comment has been minimized.

@benjaminvialle

benjaminvialle Feb 21, 2013

Member

%{request_count} demande de remarque restante.

@benjaminvialle

benjaminvialle Feb 21, 2013

Member

%{request_count} demande de remarque restante.

config/locales/fr.yml
@@ -1073,6 +1073,8 @@ fr:
assignments_submitted: "Projets envoyés :"
assignments_graded: "Projets corrigés :"
refresh_graph: "Actualiser le graphique"
+ outstanding_remark_request: "%{request_count} outstanding remark request"
+ outstanding_remark_requests: "%{request_count} outstanding remark requests"

This comment has been minimized.

@benjaminvialle

benjaminvialle Feb 21, 2013

Member

%{request_count} demandes de remarque restantes.

@benjaminvialle

benjaminvialle Feb 21, 2013

Member

%{request_count} demandes de remarque restantes.

This comment has been minimized.

@m-wu

m-wu Feb 21, 2013

Contributor

Thanks @benjaminvialle ! :)

@m-wu

m-wu Feb 21, 2013

Contributor

Thanks @benjaminvialle ! :)

@akwok18

This comment has been minimized.

Show comment
Hide comment
@akwok18

akwok18 Feb 28, 2013

Contributor

After clicking the oustanding remark requests link, I was taken to the assignments page but the ordering, although indicated as sort on marking state, was not ordered correctly.

Note: Even clicking the marking state column (twice - once to reverse, once to get desired ordering) does not order the table properly.

fromRemarkCountLink

Also noticed that if you navigate to the submissions tab not using the dashboard remark request link (eg: click the submissions tab again even though it will just show the same page), the sorting changes to sorting on Group Name although the arrows indicate that it should be sorted by marking state.

I'm not sure if we want this page to always sort on Group Name and for the link to remark requests be an exception to this or if the page should remain sorted as whatever was previously shown.

fromTabNavigation

Contributor

akwok18 commented Feb 28, 2013

After clicking the oustanding remark requests link, I was taken to the assignments page but the ordering, although indicated as sort on marking state, was not ordered correctly.

Note: Even clicking the marking state column (twice - once to reverse, once to get desired ordering) does not order the table properly.

fromRemarkCountLink

Also noticed that if you navigate to the submissions tab not using the dashboard remark request link (eg: click the submissions tab again even though it will just show the same page), the sorting changes to sorting on Group Name although the arrows indicate that it should be sorted by marking state.

I'm not sure if we want this page to always sort on Group Name and for the link to remark requests be an exception to this or if the page should remain sorted as whatever was previously shown.

fromTabNavigation

@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Feb 28, 2013

Contributor

I noticed the sorting problem too. It is a separate issue I think, so I'll log it soon and fix it later.

I thought the link on remark requests should take the user to a list of remark requests, and grouping them together on submission page, i.e. sorting by marking state, is one way to achieve that. Does that behaviour cause inconvenience or confusion to the user?

Contributor

m-wu commented Feb 28, 2013

I noticed the sorting problem too. It is a separate issue I think, so I'll log it soon and fix it later.

I thought the link on remark requests should take the user to a list of remark requests, and grouping them together on submission page, i.e. sorting by marking state, is one way to achieve that. Does that behaviour cause inconvenience or confusion to the user?

@akwok18

This comment has been minimized.

Show comment
Hide comment
@akwok18

akwok18 Feb 28, 2013

Contributor

I noticed that the sorting problem does still occur before your fix too.

I would think it would be helpful to have it sorted by marking state when the user clicks the link for outstanding remark requests. My point about the second concern I brought up was more about the sorting in general. Eg: After the user clicks the link, should any subsequent visits to the submission tab (not via that outstanding remark request link) display the list still sorted in Marking State/last column sorted by or should it return to the default sort on Group Name? It looks like currently we do not use the last column sorted by when displaying this view, but the bug is that it is not updating those arrows that indicate which column it is sorting by. Since this is also a bug that exists before your change, maybe you want to handle it in a separate issue like the sorting problem? If so, the rest of fix functionality looks good to me.

Contributor

akwok18 commented Feb 28, 2013

I noticed that the sorting problem does still occur before your fix too.

I would think it would be helpful to have it sorted by marking state when the user clicks the link for outstanding remark requests. My point about the second concern I brought up was more about the sorting in general. Eg: After the user clicks the link, should any subsequent visits to the submission tab (not via that outstanding remark request link) display the list still sorted in Marking State/last column sorted by or should it return to the default sort on Group Name? It looks like currently we do not use the last column sorted by when displaying this view, but the bug is that it is not updating those arrows that indicate which column it is sorting by. Since this is also a bug that exists before your change, maybe you want to handle it in a separate issue like the sorting problem? If so, the rest of fix functionality looks good to me.

@m-wu

This comment has been minimized.

Show comment
Hide comment
@m-wu

m-wu Mar 1, 2013

Contributor

Yes, I'll fix the sorting problems separately. Thanks so much for reviewing and finding these bugs! 😄

@reidka : @akwok18 has reviewed this fix and I think this is ready for merging.

Contributor

m-wu commented Mar 1, 2013

Yes, I'll fix the sorting problems separately. Thanks so much for reviewing and finding these bugs! 😄

@reidka : @akwok18 has reviewed this fix and I think this is ready for merging.

benjaminvialle added a commit that referenced this pull request Mar 2, 2013

Merge pull request #1011 from m-wu/issue-938
Added remark request count on dashboard.
Closes #938

@benjaminvialle benjaminvialle merged commit 711b213 into MarkUsProject:master Mar 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment