FIX for issue 941 updated database schema for submissions and results.#1026
Merged
Conversation
…. Helper methods implemented to retrieve appropriate result.
Contributor
There was a problem hiding this comment.
result is being saved twice on the next line.
Contributor
|
These changes do not cause any additional failures in the test suite, and besides the comments I made above, the pull request looks good to me. (But since I'm still relatively new to RoR, a quick scan by a pro wouldn't hurt.) |
…ed redundant result save
reidka
added a commit
that referenced
this pull request
Mar 6, 2013
FIX for issue 941 updated database schema for submissions and results. I'm going to merge this one so that work can continue on this area. There is lots of active development on this part of the code right now so hopeful any issues with it will appear soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submissions now have a one to many relationship with results (instead of one to one result and one to one remark result). Implemented methods to retrieve the correct result (remark or original) that are not relying on database ordering or timestamp. Updated blueprints and tests for updated schema. Functionality should remain the same as before the schema change.
Fix for issue #941