New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXES to issues 1016, 1018, 1031, 1021, 1030, 1051, 1049. #1052

Merged
merged 2 commits into from Mar 13, 2013

Conversation

Projects
None yet
3 participants
@akwok18
Contributor

akwok18 commented Mar 12, 2013

All related to issue #1027 - needing to update code base so that it is using the appropriate result (remark or original) instead of always using the original.

Implemented two new helper methods - get_latest_result (returns remark result if it has been submitted, else returns original) and get_latest_completed_result (returns a completed result or nil if none exist).

Fixes issues #1016, #1018, #1031, #1021, #1030, #1051 with just substituting get_original_result with the appropriate helper method.
Fixes issue #1049 with substitution and also had to update method that compares results for ordering on marking state since it was not taking into account all scenarios (including released boolean and remark request).

FIXES to issues 1016, 1018, 1031, 1021, 1030, 1049. All related to is…
…sue 1027 - needing to update code base so that it is using the appropriate result (remark or original) instead of always using the original.
@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Mar 13, 2013

Member

Could you cut your lines at 80 caracters, please?

Your code looks clean. +1 for a merge.

Member

benjaminvialle commented Mar 13, 2013

Could you cut your lines at 80 caracters, please?

Your code looks clean. +1 for a merge.

reidka added a commit that referenced this pull request Mar 13, 2013

Merge pull request #1052 from akwok18/issue-1016
FIXES to issues 1016, 1018, 1031, 1021, 1030, 1051, 1049.

@reidka reidka merged commit f722a59 into MarkUsProject:master Mar 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment