Issue 1002: Add groups controller, update submission_downloads#1062
Merged
Conversation
Created tests for controller, and also fixed a bug in submission.rb's get_submission_by_group_and_assignment
Member
|
Hi @danielstjules, All tests pass for me and the code looks very clean. You did a great work. For me, it is good to be merged. Thank you very much :) |
Contributor
Author
|
@benjaminvialle Thanks! I intend to write a wiki page with a description of the MarkUs API this coming week. I just want to finish updating test_results and adding one more route. :) |
reidka
added a commit
that referenced
this pull request
Apr 1, 2013
Issue 1002: Add groups controller, update submission_downloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to: #1002
Note: I also fixed a minor bug in submission.rb's get_submission_by_group_and_assignment. It wasn't returning null if the assignment and group both existed, but no corresponding grouping.