New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1002: Add groups controller, update submission_downloads #1062

Merged
merged 5 commits into from Apr 1, 2013

Conversation

Projects
None yet
3 participants
@danielstjules
Member

danielstjules commented Apr 1, 2013

In reference to: #1002
Note: I also fixed a minor bug in submission.rb's get_submission_by_group_and_assignment. It wasn't returning null if the assignment and group both existed, but no corresponding grouping.

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Apr 1, 2013

Member

Hi @danielstjules,

All tests pass for me and the code looks very clean. You did a great work. For me, it is good to be merged.
Maybe, later, you could add a wiki page to explain how to use MarkUs API, that would be great!

Thank you very much :)

Member

benjaminvialle commented Apr 1, 2013

Hi @danielstjules,

All tests pass for me and the code looks very clean. You did a great work. For me, it is good to be merged.
Maybe, later, you could add a wiki page to explain how to use MarkUs API, that would be great!

Thank you very much :)

@danielstjules

This comment has been minimized.

Show comment
Hide comment
@danielstjules

danielstjules Apr 1, 2013

Member

@benjaminvialle Thanks! I intend to write a wiki page with a description of the MarkUs API this coming week. I just want to finish updating test_results and adding one more route. :)

Member

danielstjules commented Apr 1, 2013

@benjaminvialle Thanks! I intend to write a wiki page with a description of the MarkUs API this coming week. I just want to finish updating test_results and adding one more route. :)

reidka added a commit that referenced this pull request Apr 1, 2013

Merge pull request #1062 from danielstjules/issue-1002
Issue 1002: Add groups controller, update submission_downloads

@reidka reidka merged commit fe97845 into MarkUsProject:master Apr 1, 2013

@danielstjules danielstjules deleted the danielstjules:issue-1002 branch Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment