New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #874 Fixed, removed nbsp #876

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@andreykul
Contributor

andreykul commented Oct 5, 2012

fixed issue #874 ,removed the extra nbsp on grader summary after marks released

Show outdated Hide outdated config/locales/en.yml
@@ -266,11 +266,11 @@ en:
old_subtotal: "Old Subtotal: "
bonus_deductions: "Bonus/Deductions"
bonus_marks: "Bonus Marks: "
deducted_marks: "Deducted Marks: "

This comment has been minimized.

@mikeing2001

mikeing2001 Oct 5, 2012

Contributor

Hi Andrey, removing the &nbsp ; shouldn't be a problem. However, i think it maybe better that we do a .html_safe on the tag it is calling thus change the &nbsp ; to a space.

@mikeing2001

mikeing2001 Oct 5, 2012

Contributor

Hi Andrey, removing the &nbsp ; shouldn't be a problem. However, i think it maybe better that we do a .html_safe on the tag it is calling thus change the &nbsp ; to a space.

Show outdated Hide outdated config/locales/en.yml
total_extra_marks: "Total Extra Marks: "
total_extra_percentages: "Total Extra Percentage: "
translated_to_points: "Translated to Points:"
final_mark: "Final Mark "
final_mark: "Final Mark"
previous_mark: "Previous Mark "

This comment has been minimized.

@mikeing2001

mikeing2001 Oct 5, 2012

Contributor

The extra space needs to be removed from here as well

@mikeing2001

mikeing2001 Oct 5, 2012

Contributor

The extra space needs to be removed from here as well

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Oct 5, 2012

Contributor

Also, 2 other comments,

  1. Can you make the fr.yml and en.yml match. for deducted_marks and bonus_marks By that I mean, in the english we have a semi colon and and in french we don't.
  2. Also, there is a formatting issue related to how the marks are shown. Currently for both bonus marks and deducted marks, the marks are displayed beside the name. However, they should be formatted so that the marks are under the mark title
Contributor

mikeing2001 commented Oct 5, 2012

Also, 2 other comments,

  1. Can you make the fr.yml and en.yml match. for deducted_marks and bonus_marks By that I mean, in the english we have a semi colon and and in french we don't.
  2. Also, there is a formatting issue related to how the marks are shown. Currently for both bonus marks and deducted marks, the marks are displayed beside the name. However, they should be formatted so that the marks are under the mark title
previous_mark: "Note précédente : "
old: "Précédent : "
bonus_marks: "Notes bonus: "
deducted_marks: "Notes déduites: "

This comment has been minimized.

@jerboaa

jerboaa Oct 12, 2012

Member

Please don't change spacing for the FR locale. Applies for all changes in fr.yml. Thanks!

@jerboaa

jerboaa Oct 12, 2012

Member

Please don't change spacing for the FR locale. Applies for all changes in fr.yml. Thanks!

@andreykul andreykul closed this Oct 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment