Issue894: Marks spreadsheet: sort by User Name, Last Name, First Name, Section.#928
Merged
Conversation
…on marks spreadsheet
Member
There was a problem hiding this comment.
This line seems a bit long. Could you reformat it to <= 80 chars?
Contributor
|
I merged this pull request on my machine, and confirmed that the new functionality works as expected. The included functional test passes as well. The code review didn't raise any red flags for me, so I'm ready to move forward with merging this pull request. @oussamaBA have you had a chance to take a look at this code yet? |
Contributor
|
I fetched this branch from Kira's repo into my machine. The functionality works as expected. |
Contributor
|
@reidka Can you merge? |
reidka
added a commit
that referenced
this pull request
Jan 30, 2013
Issue894: Marks spreadsheet: sort by User Name, Last Name, First Name, Section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review.