New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 968: Fix notice on dashboard warning users about using non-gecko based browsers #971

Merged
merged 1 commit into from Jan 20, 2013

Conversation

Projects
None yet
3 participants
@danielstjules
Member

danielstjules commented Jan 20, 2013

This is in reference to #968
Uses Prototype's browser detection. Now the notice displays as originally intended in non-gecko browsers.

@mikeing2001

This comment has been minimized.

Show comment
Hide comment
@mikeing2001

mikeing2001 Jan 20, 2013

Contributor

Good catch. Change looks good

Contributor

mikeing2001 commented Jan 20, 2013

Good catch. Change looks good

<% if !@current_user.student? %>
<p id="firefox_warning" class="notice"><%= I18n.t(:firefox_warning) %></p>
<script type="text/javascript">

This comment has been minimized.

@benjaminvialle

benjaminvialle Jan 20, 2013

Member

The js part should be located in an other file and then included in the webpage with javascript_include_tag.

@benjaminvialle

benjaminvialle Jan 20, 2013

Member

The js part should be located in an other file and then included in the webpage with javascript_include_tag.

This comment has been minimized.

@danielstjules

danielstjules Jan 20, 2013

Member

As with the other commit, did you want me to create a js file just for the included javascript? It's only 5 lines long, and applies solely to this page, which is why I originally made it embedded.

@danielstjules

danielstjules Jan 20, 2013

Member

As with the other commit, did you want me to create a js file just for the included javascript? It's only 5 lines long, and applies solely to this page, which is why I originally made it embedded.

This comment has been minimized.

@benjaminvialle

benjaminvialle Jan 20, 2013

Member

Yes, you're right. You patch is good. I am going to merge it.

@benjaminvialle

benjaminvialle Jan 20, 2013

Member

Yes, you're right. You patch is good. I am going to merge it.

benjaminvialle added a commit that referenced this pull request Jan 20, 2013

Merge pull request #971 from danielstjules/issue-968
Fix for issue 968: Fix notice on dashboard warning users about using non-gecko based browsers
Closes #968

@benjaminvialle benjaminvialle merged commit 581b7a5 into MarkUsProject:master Jan 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment