Fix for issue 968: Fix notice on dashboard warning users about using non-gecko based browsers#971
Merged
Conversation
…non-gecko based browsers
Contributor
|
Good catch. Change looks good |
Member
There was a problem hiding this comment.
The js part should be located in an other file and then included in the webpage with javascript_include_tag.
Contributor
Author
There was a problem hiding this comment.
As with the other commit, did you want me to create a js file just for the included javascript? It's only 5 lines long, and applies solely to this page, which is why I originally made it embedded.
Member
There was a problem hiding this comment.
Yes, you're right. You patch is good. I am going to merge it.
benjaminvialle
added a commit
that referenced
this pull request
Jan 20, 2013
Fix for issue 968: Fix notice on dashboard warning users about using non-gecko based browsers Closes #968
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in reference to #968
Uses Prototype's browser detection. Now the notice displays as originally intended in non-gecko browsers.