Fix for issue 617: Display a modal warning users about functionality in IE, and suggesting switching browsers. Only shown on first visit of any session at the login page#978
Conversation
…in IE, and suggesting switching browsers. Only shown on first visit of any session at the login page
There was a problem hiding this comment.
I think we should put javascript in a separate file and just include it in the view.
There was a problem hiding this comment.
Benjamin,
It doesn't seem like I can create one js file such as "browser_compatibility.js" and include the code from this and issue-968. Do you have any suggestions? I'd like to avoid creating two files, are they're related, despite being used on different pages. I could use try blocks to look for the elements, but I feel like it's far from ideal. Defining functions wouldn't help either to separate the two as you mentioned we should be moving all the js to an external file, so I wouldn't have a means of calling them.
Your input is appreciated, thanks.
There was a problem hiding this comment.
It was just a suggestion. It is also fine like that :)
Fix for issue 617: Display a modal warning users about functionality in IE, and suggesting switching browsers. Only shown on first visit of any session at the login page. Closes #617
|
Thank you |
2 participants
This is in reference to: #617
It uses a modal for consistency, and it's only displayed at the beginning of each session. Otherwise you'd receive the notification on each redirect, including login errors.