GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is in reference to: #617
It uses a modal for consistency, and it's only displayed at the beginning of each session. Otherwise you'd receive the notification on each redirect, including login errors.
Fix for issue 617: Display a modal warning users about functionality …
…in IE, and suggesting switching browsers. Only shown on first visit of any session at the login page
It doesn't seem like I can create one js file such as "browser_compatibility.js" and include the code from this and issue-968. Do you have any suggestions? I'd like to avoid creating two files, are they're related, despite being used on different pages. I could use try blocks to look for the elements, but I feel like it's far from ideal. Defining functions wouldn't help either to separate the two as you mentioned we should be moving all the js to an external file, so I wouldn't have a means of calling them.
Your input is appreciated, thanks.
It was just a suggestion. It is also fine like that :)
Merge pull request #978 from danielstjules/issue-617
Fix for issue 617: Display a modal warning users about functionality in IE, and suggesting switching browsers. Only shown on first visit of any session at the login page.