New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 617: Display a modal warning users about functionality in IE, and suggesting switching browsers. Only shown on first visit of any session at the login page #978

Merged
merged 1 commit into from Jan 20, 2013

Conversation

Projects
None yet
2 participants
@danielstjules
Member

danielstjules commented Jan 20, 2013

This is in reference to: #617
It uses a modal for consistency, and it's only displayed at the beginning of each session. Otherwise you'd receive the notification on each redirect, including login errors.

Fix for issue 617: Display a modal warning users about functionality …
…in IE, and suggesting switching browsers. Only shown on first visit of any session at the login page
<%= button_to_function "Ok", 'ie_warning_modal.close()', :tabindex => 100 %>
<div>&nbsp;</div>
</div>
<script type="text/javascript">

This comment has been minimized.

@benjaminvialle

benjaminvialle Jan 20, 2013

Member

I think we should put javascript in a separate file and just include it in the view.

@benjaminvialle

benjaminvialle Jan 20, 2013

Member

I think we should put javascript in a separate file and just include it in the view.

This comment has been minimized.

@danielstjules

danielstjules Jan 20, 2013

Member

Benjamin,
It doesn't seem like I can create one js file such as "browser_compatibility.js" and include the code from this and issue-968. Do you have any suggestions? I'd like to avoid creating two files, are they're related, despite being used on different pages. I could use try blocks to look for the elements, but I feel like it's far from ideal. Defining functions wouldn't help either to separate the two as you mentioned we should be moving all the js to an external file, so I wouldn't have a means of calling them.
Your input is appreciated, thanks.

@danielstjules

danielstjules Jan 20, 2013

Member

Benjamin,
It doesn't seem like I can create one js file such as "browser_compatibility.js" and include the code from this and issue-968. Do you have any suggestions? I'd like to avoid creating two files, are they're related, despite being used on different pages. I could use try blocks to look for the elements, but I feel like it's far from ideal. Defining functions wouldn't help either to separate the two as you mentioned we should be moving all the js to an external file, so I wouldn't have a means of calling them.
Your input is appreciated, thanks.

This comment has been minimized.

@benjaminvialle

benjaminvialle Jan 20, 2013

Member

It was just a suggestion. It is also fine like that :)

@benjaminvialle

benjaminvialle Jan 20, 2013

Member

It was just a suggestion. It is also fine like that :)

benjaminvialle added a commit that referenced this pull request Jan 20, 2013

Merge pull request #978 from danielstjules/issue-617
Fix for issue 617: Display a modal warning users about functionality in IE, and suggesting switching browsers. Only shown on first visit of any session at the login page.
Closes #617

@benjaminvialle benjaminvialle merged commit 43105ad into MarkUsProject:master Jan 20, 2013

@benjaminvialle

This comment has been minimized.

Show comment
Hide comment
@benjaminvialle

benjaminvialle Jan 20, 2013

Member

Thank you

Member

benjaminvialle commented Jan 20, 2013

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment