Skip to content

FIX for issue 915, added median, number of fails and number of zeros to dashboard#998

Merged
benjaminvialle merged 5 commits into
MarkUsProject:masterfrom
m-wu:issue-915
Feb 26, 2013
Merged

FIX for issue 915, added median, number of fails and number of zeros to dashboard#998
benjaminvialle merged 5 commits into
MarkUsProject:masterfrom
m-wu:issue-915

Conversation

@m-wu

@m-wu m-wu commented Feb 4, 2013

Copy link
Copy Markdown
Contributor

Added median, number of fails and number of zeros to dashboard (#915).
Adjusted dashboard UI so that all of the assignment statistics are aligned in a column.
French translations for “Number of zeros” and “Number of fails” are needed to replace the English placeholders.

Comment thread config/locales/fr.yml Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put a space between %{percentage} and % symbol :)

@benjaminvialle

Copy link
Copy Markdown
Member

French translations updated. Thanks for your work.

@m-wu

m-wu commented Feb 4, 2013

Copy link
Copy Markdown
Contributor Author

Thanks @benjaminvialle !

Comment thread db/schema.rb Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't modify schema.rb by hand. You need to create a migration a then run bundle exec rake db:migrate (see http://guides.rubyonrails.org/migrations.html)

@m-wu

m-wu commented Feb 5, 2013

Copy link
Copy Markdown
Contributor Author

@benjaminvialle Sorry for not reading comments in the code carefully. I just created a migration. Please let me know if it's correct. Thanks!

Comment thread db/schema.rb Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this. It's required for ruby 1.9 compatibility.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it back. It wasn't automatically generated after I ran the migration. Thanks!

@benjaminvialle

Copy link
Copy Markdown
Member

Thank you for your patch :)

benjaminvialle added a commit that referenced this pull request Feb 26, 2013
Added median, number of fails and number of zeros to dashboard.
Closes #915
@benjaminvialle benjaminvialle merged commit a21d15d into MarkUsProject:master Feb 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants