Skip to content

improved StrictMode behavior of Evaluate JavaScript #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Snooz82 merged 3 commits into from
Jun 15, 2022
Merged

improved StrictMode behavior of Evaluate JavaScript #2109

Snooz82 merged 3 commits into from
Jun 15, 2022

Conversation

@Snooz82
Copy link
Member

@Snooz82 Snooz82 commented Jun 13, 2022

With Evaluate JavaScript ,when Strict Mode was False and all_elements was True it always only handled one single element, because findLocator() had set firstOnly to True.

Now it behaves same with and without strict mode as long as all_elements is True.
Strict Mode is only relevant for single element mode...

@Snooz82 Snooz82 added the enhancement New feature or request label Jun 13, 2022
@Snooz82 Snooz82 added this to the V13.2.0 milestone Jun 13, 2022
@Snooz82 Snooz82 self-assigned this Jun 13, 2022
@Snooz82 Snooz82 mentioned this pull request Jun 13, 2022
Closed
@Snooz82 Snooz82 merged commit cd0526a into main Jun 15, 2022
@Snooz82 Snooz82 deleted the topic/improve_EvalJS branch June 15, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Snooz82 Snooz82

Labels

enhancement New feature or request priority: high

Projects

None yet

Milestone

v13.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Snooz82 @aaltat