diff --git a/Browser/keywords/playwright_state.py b/Browser/keywords/playwright_state.py index e38a6ff53..5cf54e4e1 100755 --- a/Browser/keywords/playwright_state.py +++ b/Browser/keywords/playwright_state.py @@ -492,8 +492,7 @@ def new_browser( """ params = locals_to_params(locals()) params = convert_typed_dict(self.new_context.__annotations__, params) - if timeout: - params["timeout"] = self.convert_timeout(timeout) + params["timeout"] = self.convert_timeout(timeout) params["slowMo"] = self.convert_timeout(slowMo) browser_path = self.library.external_browser_executable.get(browser) diff --git a/atest/test/01_Browser_Management/open_browser.robot b/atest/test/01_Browser_Management/open_browser.robot new file mode 100644 index 000000000..f8143e537 --- /dev/null +++ b/atest/test/01_Browser_Management/open_browser.robot @@ -0,0 +1,14 @@ +*** Settings *** +Resource imports.resource + +Test Teardown Close Browser ALL + +*** Test Cases *** +Open Browser With Timeout Of Zero Seconds + New Browser browser=${BROWSER} headless=${HEADLESS} timeout=0 seconds + New Browser browser=${BROWSER} headless=${HEADLESS} timeout=0 second + New Browser browser=${BROWSER} headless=${HEADLESS} timeout=0 s + New Browser browser=${BROWSER} headless=${HEADLESS} timeout=0s + +Open Browser With Default Timeout + New Browser browser=${BROWSER} headless=${HEADLESS} diff --git a/utest/test_python_usage.py b/utest/test_python_usage.py index cd9ca340e..450ca4c2d 100644 --- a/utest/test_python_usage.py +++ b/utest/test_python_usage.py @@ -5,6 +5,8 @@ import pytest from assertionengine import AssertionOperator +from Browser import SupportedBrowsers + @pytest.fixture() def application_server(): @@ -49,6 +51,16 @@ def test_new_browser_and_close(browser): browser.close_browser() +def test_new_browser_with_timeout_of_zero_seconds(browser): + browser.new_browser(browser=SupportedBrowsers.chromium, headless=True, timeout="0") + browser.close_browser("ALL") + + +def test_new_browser_with_default_timeout(browser): + browser.new_browser(browser=SupportedBrowsers.chromium, headless=True) + browser.close_browser("ALL") + + def test_playwright_exit_handler(atexit_register): import Browser